Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add to the txs cli, a command to set a multisig #247

Open
dboreham opened this issue Jun 1, 2024 · 1 comment
Open

Feature: Add to the txs cli, a command to set a multisig #247

dboreham opened this issue Jun 1, 2024 · 1 comment

Comments

@dboreham
Copy link
Contributor

dboreham commented Jun 1, 2024

From @hemulin

Description:
As part of the v7 codebase, we have a multisig capabilities out-of-the-box. An account can be set as a multisig. The Libra_framework supposedly has the methods available to be called, all is missing is a CLI command that will call them.

As inspiration, one can look at the Community wallet awakening process. An example command would be:

libra txs community gov-init -a SIGNER_1_ADDRESS -a SIGNER_2_ADDRESS -a SIGNER_N_ADDRESS -n 2

Where the -n flag is the minimum quorum of signers to approve a tx.

This command I believe is calling

Down the stack, I think it also calls the multisig creation

The task is to add to the txs cli tool, a command that will take a similar input, signer addresses and a quorum, will submit this onchain, and report back once completed.

Additionally, while there, CLI addition to manage the multisig (add/remove signers) would also be helpful.

CLI to generate txfer transactions from such a multisig account maybe something like:
libra txs propose --recipient 0x015D24D20F115C4A8224651C9F345EBA8E239DD8E9C05DE62AD0B0048473B01D --amount 100

@0o-de-lally 0o-de-lally added this to Eng Jun 8, 2024
@0o-de-lally 0o-de-lally moved this to Backlog in Eng Jun 8, 2024
@soaresa
Copy link
Contributor

soaresa commented Jun 13, 2024

@dboreham , the feature I'm implementing for issue #227 is related to this issue (#247). The changes in #227 will modify the authority assignment flow and the multisign account setting process. This will impact how the CLI commands for multisig setup and management are implemented.

@0o-de-lally 0o-de-lally moved this from Backlog to Ready in Eng Jul 12, 2024
@0o-de-lally 0o-de-lally moved this from Ready to In review in Eng Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants