Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Server] Only allow wallets with quorum === 1 for DEBUG mode #31

Open
0xBEEFCAF3 opened this issue May 6, 2023 · 3 comments
Open

[Server] Only allow wallets with quorum === 1 for DEBUG mode #31

0xBEEFCAF3 opened this issue May 6, 2023 · 3 comments

Comments

@0xBEEFCAF3
Copy link
Owner

No description provided.

@satsie
Copy link
Collaborator

satsie commented May 8, 2023

Is it helpful to allow a quorum of 1 for testing? Will MuSig work with a quorum of 1?

@0xBEEFCAF3
Copy link
Owner Author

Good question. It does work, and i've used it tons when testing. We should have some kinda of SERVER_ENV config to enable/disable this

@ronaldstoner
Copy link
Collaborator

I'm always partial to a DEBUG=True (in addition to having it set the logging level) for something like this, but I defer to the experts.

@satsie satsie changed the title [Server] Should not create wallet with quorum === 1 [Server] Only allow wallets with quorum === 1 for DEBUG mode May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@satsie @ronaldstoner @0xBEEFCAF3