Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with table based encoders #26

Open
B-Thomas opened this issue Jan 2, 2018 · 1 comment
Open

Issue with table based encoders #26

B-Thomas opened this issue Jan 2, 2018 · 1 comment

Comments

@B-Thomas
Copy link

B-Thomas commented Jan 2, 2018

In line 92 of ClickEncoder.cpp the value of the lookup table (+1 / 0 / -1) is stored in a uint8_t datatype, instead it should be stored in an int8_t type according to the possible values.

uint8_t tbl = pgm_read_byte(&table[last]);
if (tbl) {
Serial.println(tbl);
delta += tbl;
moved = true;
}

@soligen2010
Copy link

Just FYI, this fix as well as other bug fixes and enhancements are in my fork of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants