Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: VectorStoreIndex top_n function returns embed data #99

Closed
1 task done
marieaurore123 opened this issue Nov 12, 2024 · 1 comment
Closed
1 task done

bug: VectorStoreIndex top_n function returns embed data #99

marieaurore123 opened this issue Nov 12, 2024 · 1 comment

Comments

@marieaurore123
Copy link
Contributor

  • I have looked for existing issues (including closed) about this

top_n function returns Vec<(f64, String, T)> where T is converted to a serde_json::Value by the VectorStoreIndexDyn.

This becomes a problem because there is no point where the embedding vectors are filtered out of the vector search response.

Then, the agent takes as input this dynamic context and passes all the vectors as part of the context to the provider.

This makes the context window huge = more expensive and way slower.

@mateobelanger mateobelanger changed the title bug: VectorStoreIndex top_n function returns all vectors bug: VectorStoreIndex top_n function returns embed data Nov 19, 2024
@mateobelanger mateobelanger removed the bug label Nov 19, 2024
@cvauclair
Copy link
Contributor

Closed by #118 #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants