Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC URL Leak in error message #1529

Closed
praetoriansentry opened this issue Dec 2, 2024 · 0 comments · Fixed by #1533
Closed

RPC URL Leak in error message #1529

praetoriansentry opened this issue Dec 2, 2024 · 0 comments · Fixed by #1533
Assignees
@MorettiGeorgiev
Labels
bug Something isn't working
Milestone
v2.61.x (forkid.13)

Comments

@praetoriansentry
Copy link

It looks like one of the calls in polycli monitor ends up requiring a call to the L1 RPC. It's probably a call to get the gas price or something like that. But it looks like if the L1 RPC fails to respond, the full L1 URL is returned in the error response:

image

In some cases this URL will have private API keys and should not be exposed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MorettiGeorgiev MorettiGeorgiev

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.61.x (forkid.13)
Development

Successfully merging a pull request may close this issue.

fix: replace L1 rpc url in error for getting l1 gas price 0xPolygonHermez/cdk-erigon
2 participants
@praetoriansentry @MorettiGeorgiev