Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage ethereum based identities #200

Merged
merged 38 commits into from
Apr 12, 2024
Merged

Conversation

daveroga
Copy link
Contributor

@daveroga daveroga commented Mar 22, 2024

  • Manage ethereum based identities.
  1. Implement create method.
    a. add bjj key Auth credential.
    b. first state transtition must be mandatory after adding the Auth credential.
  2. Implement state transition for ethereum identities. (transitState / transitStateGeneric)
  3. Test flow when ethereum based identity is an issuer.
  • Fix for sec256k1 when private key generation is less than 32 bytes in hex representation

Review

  1. We need to sign a new auth bjj key with old one (e.g. k2 with k1). If there is no k1 and state is genesis - we can add MTP as now.
  2. For ethereum identity and for k2 we can add Iden3SparseMerkeTreeProof after the state transition.
  3. Write some tests for key rotation / adding new keys.

@daveroga daveroga changed the title Feature/ethereum based identities manage ethereum based identities Mar 22, 2024
@daveroga daveroga changed the title manage ethereum based identities WIP: manage ethereum based identities Mar 28, 2024
@daveroga daveroga marked this pull request as ready for review March 28, 2024 22:39
@daveroga daveroga changed the title WIP: manage ethereum based identities Manage ethereum based identities Mar 28, 2024
src/credentials/status/reverse-sparse-merkle-tree.ts Outdated Show resolved Hide resolved
src/credentials/status/reverse-sparse-merkle-tree.ts Outdated Show resolved Hide resolved
src/identity/identity-wallet.ts Outdated Show resolved Hide resolved
src/identity/identity-wallet.ts Outdated Show resolved Hide resolved
src/identity/identity-wallet.ts Show resolved Hide resolved
src/identity/identity-wallet.ts Outdated Show resolved Hide resolved
src/identity/identity-wallet.ts Outdated Show resolved Hide resolved
src/proof/proof-service.ts Outdated Show resolved Hide resolved
src/storage/blockchain/state.ts Outdated Show resolved Hide resolved
src/storage/interfaces/state.ts Outdated Show resolved Hide resolved
@daveroga daveroga force-pushed the feature/ethereum-based-identities branch from 89261ab to 39a2dfa Compare April 2, 2024 16:50
@daveroga daveroga force-pushed the feature/ethereum-based-identities branch from 26913e9 to adb1b08 Compare April 3, 2024 00:52
@daveroga daveroga force-pushed the feature/ethereum-based-identities branch from adb1b08 to d6740c1 Compare April 3, 2024 00:53
@daveroga daveroga requested a review from vmidyllic April 3, 2024 05:56
@0xPolygonID 0xPolygonID deleted a comment from gitguardian bot Apr 3, 2024
src/identity/identity-wallet.ts Outdated Show resolved Hide resolved
src/identity/identity-wallet.ts Outdated Show resolved Hide resolved
src/identity/identity-wallet.ts Outdated Show resolved Hide resolved
src/identity/identity-wallet.ts Outdated Show resolved Hide resolved
src/storage/blockchain/state.ts Outdated Show resolved Hide resolved
src/utils/did-helper.ts Outdated Show resolved Hide resolved
@daveroga daveroga force-pushed the feature/ethereum-based-identities branch from a451485 to a6eba8a Compare April 8, 2024 16:22
@daveroga daveroga requested a review from Kolezhniuk April 8, 2024 18:24
tests/handlers/auth.test.ts Show resolved Hide resolved
tests/handlers/auth.test.ts Show resolved Hide resolved
@daveroga daveroga requested a review from vmidyllic April 8, 2024 21:56
@daveroga daveroga force-pushed the feature/ethereum-based-identities branch from 6d52780 to 60a0c50 Compare April 9, 2024 07:29
@daveroga daveroga force-pushed the feature/ethereum-based-identities branch 3 times, most recently from c85bfbc to 1b7bc8f Compare April 9, 2024 09:16
@daveroga daveroga force-pushed the feature/ethereum-based-identities branch from 1b7bc8f to f6728c9 Compare April 9, 2024 09:40
@daveroga daveroga requested a review from vmidyllic April 10, 2024 14:44
Kolezhniuk
Kolezhniuk previously approved these changes Apr 11, 2024
Copy link
Collaborator

@Kolezhniuk Kolezhniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge latest develop and make sure that tests points to Amoy network

tests/identity/id.test.ts Outdated Show resolved Hide resolved
@vmidyllic vmidyllic merged commit a0f3e8c into main Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants