From d48fad31a4cbc5a8346322f93b2ce084aed57c44 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Wed, 1 Nov 2023 11:51:05 +0530 Subject: [PATCH 01/34] added trunk check job --- .github/workflows/build.yml | 16 +++++++++++++++- .trunk/trunk.yaml | 3 ++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 9c2e19ed4..5554b7ae9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,6 +27,20 @@ on: - "**.txt" jobs: + check_lint_errors: + name: Trunk Check Runner + runs-on: ubuntu-latest + permissions: + checks: write + contents: read + + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Trunk Check + uses: trunk-io/trunk-action@v1 + build_apk: if: github.event.pull_request.draft == false runs-on: ubuntu-latest @@ -34,7 +48,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - uses: actions/setup-java@v3 with: distribution: zulu diff --git a/.trunk/trunk.yaml b/.trunk/trunk.yaml index 7b42f1aa2..fdc1413f6 100644 --- a/.trunk/trunk.yaml +++ b/.trunk/trunk.yaml @@ -8,6 +8,8 @@ plugins: uri: https://github.com/trunk-io/plugins lint: enabled: + - swiftlint@0.53.0 + - eslint@8.52.0 - checkov@2.4.9 - osv-scanner@1.4.0 - trivy@0.45.1 @@ -16,7 +18,6 @@ lint: - yamllint@1.32.0 - ktlint@1.0.0 - svgo@3.0.2 - - prettier@3.0.3 - shfmt@3.6.0 - gitleaks@8.18.0 - shellcheck@0.9.0 From b270add0ca4b0107caf6606197233b584a427a2e Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Wed, 1 Nov 2023 21:32:16 +0530 Subject: [PATCH 02/34] updated yml --- .github/workflows/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5554b7ae9..90d5d7f10 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -9,7 +9,6 @@ on: push: branches: - main - - develop pull_request: types: - opened @@ -30,6 +29,7 @@ jobs: check_lint_errors: name: Trunk Check Runner runs-on: ubuntu-latest + # trunk-ignore(checkov/CKV2_GHA_1) permissions: checks: write contents: read @@ -42,6 +42,7 @@ jobs: uses: trunk-io/trunk-action@v1 build_apk: + name: Build APK if: github.event.pull_request.draft == false runs-on: ubuntu-latest timeout-minutes: 30 From 032e3c7c2b4a56115df946b600be15b776508c8f Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Wed, 1 Nov 2023 21:37:35 +0530 Subject: [PATCH 03/34] updated yml --- .github/workflows/build.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 90d5d7f10..5bb240bd8 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -40,6 +40,8 @@ jobs: - name: Trunk Check uses: trunk-io/trunk-action@v1 + with: + post-annotations: true build_apk: name: Build APK From ad6de7cfd4a4a7cea8a569f9dcf542b02679abd3 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Wed, 1 Nov 2023 22:01:25 +0530 Subject: [PATCH 04/34] updated yml --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5bb240bd8..c31d3c108 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -36,7 +36,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v4 - name: Trunk Check uses: trunk-io/trunk-action@v1 @@ -66,4 +66,4 @@ jobs: - name: Generate App APK run: | cd packages/react-native-room-kit/example/android - ./gradlew assembleDebug --no-daemon + ./gradlew assembleDebug From 2a972c99892a297420a9deddcc2de5665fd4f871 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Wed, 1 Nov 2023 22:13:30 +0530 Subject: [PATCH 05/34] updated build.gradle settings --- .github/workflows/build.yml | 2 +- .../react-native-room-kit/example/android/app/build.gradle | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c31d3c108..56e0ceb06 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -66,4 +66,4 @@ jobs: - name: Generate App APK run: | cd packages/react-native-room-kit/example/android - ./gradlew assembleDebug + ./gradlew assembleDebug --no-daemon diff --git a/packages/react-native-room-kit/example/android/app/build.gradle b/packages/react-native-room-kit/example/android/app/build.gradle index 34ebc041d..cfba34739 100644 --- a/packages/react-native-room-kit/example/android/app/build.gradle +++ b/packages/react-native-room-kit/example/android/app/build.gradle @@ -156,6 +156,9 @@ android { keyPassword 'android' } } + packagingOptions { + pickFirst '**/*.so' + } buildTypes { debug { minifyEnabled false From 9f1deee825d67392697e30748c5eec5ed59d1f85 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Wed, 1 Nov 2023 22:33:42 +0530 Subject: [PATCH 06/34] updated yml --- .github/workflows/build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 56e0ceb06..1aa31c00d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -56,7 +56,6 @@ jobs: with: distribution: zulu java-version: 11.x - - uses: actions/checkout@v3 - name: Install dependencies run: cd packages/react-native-room-kit/example/; npm install From 5a5b5447b7f35da39c3bdd0515e6eae90d530f33 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Wed, 1 Nov 2023 22:46:10 +0530 Subject: [PATCH 07/34] added release apps script --- .github/workflows/release-apps.yml | 51 ++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 .github/workflows/release-apps.yml diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml new file mode 100644 index 000000000..748d3e331 --- /dev/null +++ b/.github/workflows/release-apps.yml @@ -0,0 +1,51 @@ +name: Release + +concurrency: + group: ${{ github.workflow }}-${{ github.head_ref }} + cancel-in-progress: true + +on: + workflow_dispatch: + pull_request: + types: + - opened + - reopened + - synchronize + - ready_for_review + branches: + - main + - develop + paths-ignore: + - "**.md" + - doc/** + - .git/ + - .vscode/ + - "**.txt" + +jobs: + + release_apk: + name: Release Android APK + if: github.event.pull_request.draft == false + runs-on: ubuntu-latest + timeout-minutes: 30 + + steps: + - name: Checkout repository + uses: actions/checkout@v4 + - uses: actions/setup-java@v3 + with: + distribution: zulu + java-version: 11.x + - name: Setup Secrets + env: + ANDROID_APPFILE: ${{ secrets.ANDROID_APPFILE }} + ANDROID_FASTFILE: ${{ secrets.ANDROID_FASTFILE }} + ANDROID_PLUGINFILE: ${{ secrets.ANDROID_PLUGINFILE }} + run: | + echo $ANDROID_APPFILE > packages/react-native-room-kit/example/android/fastlane/Appfile + echo $ANDROID_FASTFILE > packages/react-native-room-kit/example/android/fastlane/Fastfile + echo $ANDROID_PLUGINFILE > packages/react-native-room-kit/example/android/fastlane/Pluginfile + cd packages/react-native-room-kit/example/android/fastlane + ls -la + git status From 37c0d0d3cebebd59b2e82d46ec45600476791cec Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Wed, 1 Nov 2023 22:53:29 +0530 Subject: [PATCH 08/34] updated script --- .github/workflows/release-apps.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index 748d3e331..ae8637e5c 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -43,7 +43,7 @@ jobs: ANDROID_FASTFILE: ${{ secrets.ANDROID_FASTFILE }} ANDROID_PLUGINFILE: ${{ secrets.ANDROID_PLUGINFILE }} run: | - echo $ANDROID_APPFILE > packages/react-native-room-kit/example/android/fastlane/Appfile + echo $ANDROID_APPFILE echo $ANDROID_FASTFILE > packages/react-native-room-kit/example/android/fastlane/Fastfile echo $ANDROID_PLUGINFILE > packages/react-native-room-kit/example/android/fastlane/Pluginfile cd packages/react-native-room-kit/example/android/fastlane From 8ddc8631efd257c88989c37d43ce89e08f313457 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 12:55:42 +0530 Subject: [PATCH 09/34] updated release yml --- .github/workflows/release-apps.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index ae8637e5c..cf3df274f 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -44,8 +44,15 @@ jobs: ANDROID_PLUGINFILE: ${{ secrets.ANDROID_PLUGINFILE }} run: | echo $ANDROID_APPFILE + echo $ANDROID_FASTFILE + echo $ANDROID_PLUGINFILE + + touch packages/react-native-room-kit/example/android/fastlane/Appfile + touch packages/react-native-room-kit/example/android/fastlane/Fastfile + touch packages/react-native-room-kit/example/android/fastlane/Pluginfile + + echo $ANDROID_APPFILE > packages/react-native-room-kit/example/android/fastlane/Appfile echo $ANDROID_FASTFILE > packages/react-native-room-kit/example/android/fastlane/Fastfile echo $ANDROID_PLUGINFILE > packages/react-native-room-kit/example/android/fastlane/Pluginfile - cd packages/react-native-room-kit/example/android/fastlane + cd packages/react-native-room-kit/example/android/ ls -la - git status From ddbb0933304790689b75366318e6d904beb667b4 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 13:21:50 +0530 Subject: [PATCH 10/34] updated release script --- .github/workflows/release-apps.yml | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index cf3df274f..a2f2c5a07 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -43,16 +43,12 @@ jobs: ANDROID_FASTFILE: ${{ secrets.ANDROID_FASTFILE }} ANDROID_PLUGINFILE: ${{ secrets.ANDROID_PLUGINFILE }} run: | - echo $ANDROID_APPFILE - echo $ANDROID_FASTFILE - echo $ANDROID_PLUGINFILE + cd packages/react-native-room-kit/example/android + mkdir fastlane + cd fastlane - touch packages/react-native-room-kit/example/android/fastlane/Appfile - touch packages/react-native-room-kit/example/android/fastlane/Fastfile - touch packages/react-native-room-kit/example/android/fastlane/Pluginfile + echo $ANDROID_APPFILE > Appfile + echo $ANDROID_FASTFILE > Fastfile + echo $ANDROID_PLUGINFILE > Pluginfile - echo $ANDROID_APPFILE > packages/react-native-room-kit/example/android/fastlane/Appfile - echo $ANDROID_FASTFILE > packages/react-native-room-kit/example/android/fastlane/Fastfile - echo $ANDROID_PLUGINFILE > packages/react-native-room-kit/example/android/fastlane/Pluginfile - cd packages/react-native-room-kit/example/android/ ls -la From fd46fc590b5eece6c78f5ee36169efb8f64a6169 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 13:28:25 +0530 Subject: [PATCH 11/34] creating iOS fastlane files --- .github/workflows/release-apps.yml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index a2f2c5a07..8ad225e12 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -37,11 +37,14 @@ jobs: with: distribution: zulu java-version: 11.x - - name: Setup Secrets + - name: Setup Fastlane env: ANDROID_APPFILE: ${{ secrets.ANDROID_APPFILE }} ANDROID_FASTFILE: ${{ secrets.ANDROID_FASTFILE }} ANDROID_PLUGINFILE: ${{ secrets.ANDROID_PLUGINFILE }} + IOS_APPFILE: ${{ secrets.IOS_APPFILE }} + IOS_FASTFILE: ${{ secrets.IOS_FASTFILE }} + IOS_PLUGINFILE: ${{ secrets.IOS_PLUGINFILE }} run: | cd packages/react-native-room-kit/example/android mkdir fastlane @@ -50,5 +53,15 @@ jobs: echo $ANDROID_APPFILE > Appfile echo $ANDROID_FASTFILE > Fastfile echo $ANDROID_PLUGINFILE > Pluginfile + pwd + ls -la + cd ../ios + pwd + mkdir fastlane + cd fastlane + echo $IOS_APPFILE > Appfile + echo $IOS_FASTFILE > Fastfile + echo $IOS_PLUGINFILE > Pluginfile + pwd ls -la From 93f79121bbebd8dab6334f1de376407f41b6d36b Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 13:29:36 +0530 Subject: [PATCH 12/34] corrected iOS path --- .github/workflows/release-apps.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index 8ad225e12..02cc68aa0 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -56,7 +56,7 @@ jobs: pwd ls -la - cd ../ios + cd ../../ios pwd mkdir fastlane cd fastlane From e618c94714ca9417481af48e8bedc71e14b16d68 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 13:42:35 +0530 Subject: [PATCH 13/34] added reactnative-hms.json file --- .github/workflows/release-apps.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index 02cc68aa0..ab388236c 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -39,6 +39,7 @@ jobs: java-version: 11.x - name: Setup Fastlane env: + REACT_NATIVE_HMS_JSON: ${{ secrets.REACT_NATIVE_HMS_JSON }} ANDROID_APPFILE: ${{ secrets.ANDROID_APPFILE }} ANDROID_FASTFILE: ${{ secrets.ANDROID_FASTFILE }} ANDROID_PLUGINFILE: ${{ secrets.ANDROID_PLUGINFILE }} @@ -47,6 +48,9 @@ jobs: IOS_PLUGINFILE: ${{ secrets.IOS_PLUGINFILE }} run: | cd packages/react-native-room-kit/example/android + + echo $REACT_NATIVE_HMS_JSON > reactnative-hms-a32ef61302c5.json + mkdir fastlane cd fastlane @@ -57,6 +61,8 @@ jobs: ls -la cd ../../ios + echo $REACT_NATIVE_HMS_JSON > reactnative-hms-a32ef61302c5.json + pwd mkdir fastlane cd fastlane From 118d53d21d5e7e3d9a657a3ac0253414360d5521 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:01:34 +0530 Subject: [PATCH 14/34] updated release script to run only Android build --- release-apps.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/release-apps.sh b/release-apps.sh index a7ee1bb71..bb3d839c6 100644 --- a/release-apps.sh +++ b/release-apps.sh @@ -25,13 +25,14 @@ release_android() { } release_iOS() { - cd ./ios + pwd + # cd ./ios - pod install --verbose + # pod install --verbose - bundle install --verbose + # bundle install --verbose - bundle exec fastlane distribute_app + # bundle exec fastlane distribute_app } perform_git_actions() { From bf0fdf97005498f706f2ebc56931e3c833874a99 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:01:42 +0530 Subject: [PATCH 15/34] updated script --- .github/workflows/release-apps.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index ab388236c..18313f69c 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -71,3 +71,5 @@ jobs: echo $IOS_PLUGINFILE > Pluginfile pwd ls -la + - name: Run Release Script + run: sh release-apps.sh From cf4e0b6b057951a1f802daf86c1dc4bf10420b0f Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:05:28 +0530 Subject: [PATCH 16/34] removed git pull step --- release-apps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release-apps.sh b/release-apps.sh index bb3d839c6..a61dd66da 100644 --- a/release-apps.sh +++ b/release-apps.sh @@ -7,7 +7,7 @@ set -x perform_npm_actions() { cd ./packages/react-native-room-kit - git pull --verbose + # git pull --verbose npm install From f2d874e5292ec70852eef77c44363a2301be4140 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:08:05 +0530 Subject: [PATCH 17/34] update release script --- release-apps.sh | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/release-apps.sh b/release-apps.sh index a61dd66da..148dcca7c 100644 --- a/release-apps.sh +++ b/release-apps.sh @@ -57,18 +57,20 @@ perform_git_actions() { } perform_npm_actions -P1=$! +release_android +# perform_npm_actions +# P1=$! -wait $P1 +# wait $P1 -release_android & -P2=$! +# release_android & +# P2=$! -release_iOS & -P3=$! +# release_iOS & +# P3=$! -wait $P2 $P3 +# wait $P2 $P3 -perform_git_actions +# perform_git_actions -say done +# say done From 494cb6989329c61a68a092c0af2aca15f97c5832 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:11:19 +0530 Subject: [PATCH 18/34] added install ruby step --- .github/workflows/release-apps.yml | 2 ++ release-apps.sh | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index 18313f69c..1ee6e5610 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -37,6 +37,8 @@ jobs: with: distribution: zulu java-version: 11.x + - name: Setup Ruby + uses: actions/setup-ruby@v1 - name: Setup Fastlane env: REACT_NATIVE_HMS_JSON: ${{ secrets.REACT_NATIVE_HMS_JSON }} diff --git a/release-apps.sh b/release-apps.sh index 148dcca7c..72217e217 100644 --- a/release-apps.sh +++ b/release-apps.sh @@ -19,6 +19,8 @@ perform_npm_actions() { release_android() { cd ./android + gem install bundler + bundle install --verbose bundle exec fastlane distribute_app From 1859f399713c5f3edb89aa6398d7bd59d86dc13c Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:15:32 +0530 Subject: [PATCH 19/34] updated ruby step --- .github/workflows/release-apps.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index 1ee6e5610..69427e405 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -38,7 +38,7 @@ jobs: distribution: zulu java-version: 11.x - name: Setup Ruby - uses: actions/setup-ruby@v1 + uses: ruby/setup-ruby@v1 - name: Setup Fastlane env: REACT_NATIVE_HMS_JSON: ${{ secrets.REACT_NATIVE_HMS_JSON }} From 393b7762a674a494209d0885adb1dfa5e1a903df Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:17:18 +0530 Subject: [PATCH 20/34] updated ruby step --- .github/workflows/release-apps.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index 69427e405..e71c84e39 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -39,6 +39,8 @@ jobs: java-version: 11.x - name: Setup Ruby uses: ruby/setup-ruby@v1 + with: + ruby-version: '3.2' - name: Setup Fastlane env: REACT_NATIVE_HMS_JSON: ${{ secrets.REACT_NATIVE_HMS_JSON }} From 544a5f0f176abbd66a76b422f65cc740028e4a91 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:22:39 +0530 Subject: [PATCH 21/34] updated release script --- release-apps.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/release-apps.sh b/release-apps.sh index 72217e217..b7f1270a9 100644 --- a/release-apps.sh +++ b/release-apps.sh @@ -19,10 +19,10 @@ perform_npm_actions() { release_android() { cd ./android - gem install bundler - bundle install --verbose + fastlane add_plugin firebase_app_distribution + bundle exec fastlane distribute_app } From fbe38803d8a10a36d3e2675457628cdc10ba73d3 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:26:18 +0530 Subject: [PATCH 22/34] updated scripts --- .github/workflows/release-apps.yml | 6 -- .../example/android/fastlane/Appfile | 2 + .../example/android/fastlane/Fastfile | 56 +++++++++++++++++++ .../example/android/fastlane/Pluginfile | 5 ++ 4 files changed, 63 insertions(+), 6 deletions(-) create mode 100644 packages/react-native-room-kit/example/android/fastlane/Appfile create mode 100644 packages/react-native-room-kit/example/android/fastlane/Fastfile create mode 100644 packages/react-native-room-kit/example/android/fastlane/Pluginfile diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index e71c84e39..84aaf43d0 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -44,9 +44,6 @@ jobs: - name: Setup Fastlane env: REACT_NATIVE_HMS_JSON: ${{ secrets.REACT_NATIVE_HMS_JSON }} - ANDROID_APPFILE: ${{ secrets.ANDROID_APPFILE }} - ANDROID_FASTFILE: ${{ secrets.ANDROID_FASTFILE }} - ANDROID_PLUGINFILE: ${{ secrets.ANDROID_PLUGINFILE }} IOS_APPFILE: ${{ secrets.IOS_APPFILE }} IOS_FASTFILE: ${{ secrets.IOS_FASTFILE }} IOS_PLUGINFILE: ${{ secrets.IOS_PLUGINFILE }} @@ -58,9 +55,6 @@ jobs: mkdir fastlane cd fastlane - echo $ANDROID_APPFILE > Appfile - echo $ANDROID_FASTFILE > Fastfile - echo $ANDROID_PLUGINFILE > Pluginfile pwd ls -la diff --git a/packages/react-native-room-kit/example/android/fastlane/Appfile b/packages/react-native-room-kit/example/android/fastlane/Appfile new file mode 100644 index 000000000..c7ed72399 --- /dev/null +++ b/packages/react-native-room-kit/example/android/fastlane/Appfile @@ -0,0 +1,2 @@ +json_key_file("") # Path to the json secret file - Follow https://docs.fastlane.tools/actions/supply/#setup to get one +package_name("live.hms.rn") # e.g. com.krausefx.app diff --git a/packages/react-native-room-kit/example/android/fastlane/Fastfile b/packages/react-native-room-kit/example/android/fastlane/Fastfile new file mode 100644 index 000000000..acbf1d922 --- /dev/null +++ b/packages/react-native-room-kit/example/android/fastlane/Fastfile @@ -0,0 +1,56 @@ +update_fastlane + +default_platform(:android) + +platform :android do + desc "Firebase App Distribution" + lane :distribute_app do + + path = '../app/build.gradle' + re = /versionCode\s+(\d+)/ + vn = /versionName\s+"\d.\d.(\d+)"/ + s = File.read(path) + versionCode = s[re, 1].to_i + versionName = s[vn, 1].to_i + s[re, 1] = (versionCode+1).to_s + s[vn, 1] = (versionName+1).to_s + + updatedVersionCode = s[re, 1] + updatedVersionName = s[/versionName\s+"(\d.\d.\d+)"/, 1] + + f = File.new(path, 'w') + f.write(s) + f.close + + build_android_app( + task: 'assemble', + build_type: 'Release' + ) + + commit = last_git_commit + firebase_app_distribution( + app: "1:408505141940:android:7fae09bd993f283fc325e1", + groups: "internal, External", + service_credentials_file: "reactnative-hms-a32ef61302c5.json", + android_artifact_path: lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH], + release_notes_file: "../ExampleAppChangelog.txt" + ) + + slack( + message: ":react: 🎉 React Native Android App released! 🎊 :react:", + slack_url: "https://hooks.slack.com/services/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", + payload: { + "📲 Download from Firebase 🤖" => "https://appdistribution.firebase.dev/i/7b7ab3b30e627c35", + "📝 Changelog with Tickets" => File.read("../../ExampleAppChangelog.txt") + }, + default_payloads: ["git_branch"], + attachment_properties: { + fields: [{ + title: "🎊 App Version", + value: updatedVersionName + " (" + updatedVersionCode + ")", + short: false + }] + } + ) + end +end diff --git a/packages/react-native-room-kit/example/android/fastlane/Pluginfile b/packages/react-native-room-kit/example/android/fastlane/Pluginfile new file mode 100644 index 000000000..b18539bc9 --- /dev/null +++ b/packages/react-native-room-kit/example/android/fastlane/Pluginfile @@ -0,0 +1,5 @@ +# Autogenerated by fastlane +# +# Ensure this file is checked in to source control! + +gem 'fastlane-plugin-firebase_app_distribution' From 33b41742fe215e134e3d278c4ac6d791a0793b28 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:27:37 +0530 Subject: [PATCH 23/34] updated script --- .github/workflows/release-apps.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index 84aaf43d0..0a8fddc3d 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -52,7 +52,6 @@ jobs: echo $REACT_NATIVE_HMS_JSON > reactnative-hms-a32ef61302c5.json - mkdir fastlane cd fastlane pwd From a147ce98ff89553c6f5e1b2692d42e98ffa61b5c Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 14:41:02 +0530 Subject: [PATCH 24/34] added installing node step --- .github/workflows/release-apps.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index 0a8fddc3d..d8bac7f10 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -24,8 +24,8 @@ on: jobs: - release_apk: - name: Release Android APK + release_android: + name: Release Android App on Firebase if: github.event.pull_request.draft == false runs-on: ubuntu-latest timeout-minutes: 30 @@ -41,6 +41,10 @@ jobs: uses: ruby/setup-ruby@v1 with: ruby-version: '3.2' + - name: Setup Node + uses: actions/setup-node@v4 + with: + node-version: 16.0.0 - name: Setup Fastlane env: REACT_NATIVE_HMS_JSON: ${{ secrets.REACT_NATIVE_HMS_JSON }} From be7ae71bb4259556d7add49c84aba538852d5f2c Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 17:32:01 +0530 Subject: [PATCH 25/34] updated release script --- release-apps.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/release-apps.sh b/release-apps.sh index b7f1270a9..d0f79d152 100644 --- a/release-apps.sh +++ b/release-apps.sh @@ -5,7 +5,10 @@ set -e set -x perform_npm_actions() { - cd ./packages/react-native-room-kit + cd packages/react-native-hms + npm install + + cd ../packages/react-native-room-kit # git pull --verbose From a4b7c32bddc71eacb13282599697da454dfed442 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 17:36:37 +0530 Subject: [PATCH 26/34] updated release script --- release-apps.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release-apps.sh b/release-apps.sh index d0f79d152..47ece98c2 100644 --- a/release-apps.sh +++ b/release-apps.sh @@ -8,7 +8,7 @@ perform_npm_actions() { cd packages/react-native-hms npm install - cd ../packages/react-native-room-kit + cd ../react-native-room-kit # git pull --verbose From fc4547850b59005e170f3c9141aa26d7edfcaf8f Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 18:17:39 +0530 Subject: [PATCH 27/34] added env variables to Fastfile --- .../react-native-room-kit/example/android/fastlane/Fastfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native-room-kit/example/android/fastlane/Fastfile b/packages/react-native-room-kit/example/android/fastlane/Fastfile index acbf1d922..a8fd39bcf 100644 --- a/packages/react-native-room-kit/example/android/fastlane/Fastfile +++ b/packages/react-native-room-kit/example/android/fastlane/Fastfile @@ -29,7 +29,7 @@ platform :android do commit = last_git_commit firebase_app_distribution( - app: "1:408505141940:android:7fae09bd993f283fc325e1", + app: ENV["FIREBASE_APP_ID"], groups: "internal, External", service_credentials_file: "reactnative-hms-a32ef61302c5.json", android_artifact_path: lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH], @@ -38,7 +38,7 @@ platform :android do slack( message: ":react: 🎉 React Native Android App released! 🎊 :react:", - slack_url: "https://hooks.slack.com/services/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", + slack_url: ENV["SLACK_URL"], payload: { "📲 Download from Firebase 🤖" => "https://appdistribution.firebase.dev/i/7b7ab3b30e627c35", "📝 Changelog with Tickets" => File.read("../../ExampleAppChangelog.txt") From a313623843310f5d963a7bd817dc8fccb836b59a Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 18:39:02 +0530 Subject: [PATCH 28/34] getting secrets as ENV variables --- .github/workflows/release-apps.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index d8bac7f10..24cb5ed71 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -48,6 +48,8 @@ jobs: - name: Setup Fastlane env: REACT_NATIVE_HMS_JSON: ${{ secrets.REACT_NATIVE_HMS_JSON }} + FIREBASE_APP_ID: ${{ secrets.FIREBASE_APP_ID }} + SLACK_URL: ${{ secrets.SLACK_URL }} IOS_APPFILE: ${{ secrets.IOS_APPFILE }} IOS_FASTFILE: ${{ secrets.IOS_FASTFILE }} IOS_PLUGINFILE: ${{ secrets.IOS_PLUGINFILE }} From 9b4c34870096e84c49bc61ae158f35f9b7195c76 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 20:10:50 +0530 Subject: [PATCH 29/34] using env variables from github action --- .../react-native-room-kit/example/android/fastlane/Fastfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native-room-kit/example/android/fastlane/Fastfile b/packages/react-native-room-kit/example/android/fastlane/Fastfile index a8fd39bcf..db12113a3 100644 --- a/packages/react-native-room-kit/example/android/fastlane/Fastfile +++ b/packages/react-native-room-kit/example/android/fastlane/Fastfile @@ -29,7 +29,7 @@ platform :android do commit = last_git_commit firebase_app_distribution( - app: ENV["FIREBASE_APP_ID"], + app: $FIREBASE_APP_ID, groups: "internal, External", service_credentials_file: "reactnative-hms-a32ef61302c5.json", android_artifact_path: lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH], @@ -38,7 +38,7 @@ platform :android do slack( message: ":react: 🎉 React Native Android App released! 🎊 :react:", - slack_url: ENV["SLACK_URL"], + slack_url: $SLACK_URL, payload: { "📲 Download from Firebase 🤖" => "https://appdistribution.firebase.dev/i/7b7ab3b30e627c35", "📝 Changelog with Tickets" => File.read("../../ExampleAppChangelog.txt") From 82bdf0cc353de998b5ab1630c285168c78d6c5fb Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Thu, 2 Nov 2023 21:00:57 +0530 Subject: [PATCH 30/34] using shell command output in fastfile --- .../react-native-room-kit/example/android/fastlane/Fastfile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/react-native-room-kit/example/android/fastlane/Fastfile b/packages/react-native-room-kit/example/android/fastlane/Fastfile index db12113a3..c16919adf 100644 --- a/packages/react-native-room-kit/example/android/fastlane/Fastfile +++ b/packages/react-native-room-kit/example/android/fastlane/Fastfile @@ -28,17 +28,19 @@ platform :android do ) commit = last_git_commit + firebaseID = sh("$FIREBASE_APP_ID") firebase_app_distribution( - app: $FIREBASE_APP_ID, + app: firebaseID, groups: "internal, External", service_credentials_file: "reactnative-hms-a32ef61302c5.json", android_artifact_path: lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH], release_notes_file: "../ExampleAppChangelog.txt" ) + slackUrl = sh("$SLACK_URL") slack( message: ":react: 🎉 React Native Android App released! 🎊 :react:", - slack_url: $SLACK_URL, + slack_url: slackUrl, payload: { "📲 Download from Firebase 🤖" => "https://appdistribution.firebase.dev/i/7b7ab3b30e627c35", "📝 Changelog with Tickets" => File.read("../../ExampleAppChangelog.txt") From 1593d78168c47c3832812458de2a2fe9897d3747 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Fri, 3 Nov 2023 11:56:40 +0530 Subject: [PATCH 31/34] passing params to fastlane --- .../example/android/Gemfile.lock | 26 +++++++++---------- .../example/android/fastlane/Fastfile | 8 +++--- .../example/ios/Gemfile.lock | 14 +++++----- release-apps.sh | 7 +++-- 4 files changed, 26 insertions(+), 29 deletions(-) diff --git a/packages/react-native-room-kit/example/android/Gemfile.lock b/packages/react-native-room-kit/example/android/Gemfile.lock index d7921f828..f7f157dc3 100644 --- a/packages/react-native-room-kit/example/android/Gemfile.lock +++ b/packages/react-native-room-kit/example/android/Gemfile.lock @@ -8,20 +8,20 @@ GEM artifactory (3.0.15) atomos (0.1.3) aws-eventstream (1.2.0) - aws-partitions (1.826.0) - aws-sdk-core (3.183.0) + aws-partitions (1.843.0) + aws-sdk-core (3.185.2) aws-eventstream (~> 1, >= 1.0.2) aws-partitions (~> 1, >= 1.651.0) aws-sigv4 (~> 1.5) jmespath (~> 1, >= 1.6.1) - aws-sdk-kms (1.71.0) - aws-sdk-core (~> 3, >= 3.177.0) + aws-sdk-kms (1.72.0) + aws-sdk-core (~> 3, >= 3.184.0) aws-sigv4 (~> 1.1) - aws-sdk-s3 (1.135.0) + aws-sdk-s3 (1.136.0) aws-sdk-core (~> 3, >= 3.181.0) aws-sdk-kms (~> 1) aws-sigv4 (~> 1.6) - aws-sigv4 (1.6.0) + aws-sigv4 (1.6.1) aws-eventstream (~> 1, >= 1.0.2) babosa (1.0.4) claide (1.1.0) @@ -36,7 +36,7 @@ GEM unf (>= 0.0.5, < 1.0.0) dotenv (2.8.1) emoji_regex (3.2.3) - excon (0.103.0) + excon (0.104.0) faraday (1.10.3) faraday-em_http (~> 1.0) faraday-em_synchrony (~> 1.0) @@ -109,9 +109,9 @@ GEM fastlane-plugin-firebase_app_distribution (0.7.4) google-apis-firebaseappdistribution_v1 (~> 0.3.0) gh_inspector (1.1.3) - google-apis-androidpublisher_v3 (0.49.0) + google-apis-androidpublisher_v3 (0.51.0) google-apis-core (>= 0.11.0, < 2.a) - google-apis-core (0.11.1) + google-apis-core (0.11.2) addressable (~> 2.5, >= 2.5.1) googleauth (>= 0.16.2, < 2.a) httpclient (>= 2.8.1, < 3.a) @@ -165,7 +165,7 @@ GEM os (1.1.4) plist (3.7.0) public_suffix (5.0.3) - rake (13.0.6) + rake (13.1.0) representable (3.2.0) declarative (< 0.1.0) trailblazer-option (>= 0.1.1, < 0.2.0) @@ -196,10 +196,10 @@ GEM unf (0.1.4) unf_ext unf_ext (0.0.8.2) - unicode-display_width (2.4.2) + unicode-display_width (2.5.0) webrick (1.8.1) word_wrap (1.0.0) - xcodeproj (1.22.0) + xcodeproj (1.23.0) CFPropertyList (>= 2.3.3, < 4.0) atomos (~> 0.1.3) claide (>= 1.0.2, < 2.0) @@ -219,4 +219,4 @@ DEPENDENCIES fastlane-plugin-firebase_app_distribution BUNDLED WITH - 2.4.13 + 2.4.21 diff --git a/packages/react-native-room-kit/example/android/fastlane/Fastfile b/packages/react-native-room-kit/example/android/fastlane/Fastfile index c16919adf..d90b37bf0 100644 --- a/packages/react-native-room-kit/example/android/fastlane/Fastfile +++ b/packages/react-native-room-kit/example/android/fastlane/Fastfile @@ -4,7 +4,7 @@ default_platform(:android) platform :android do desc "Firebase App Distribution" - lane :distribute_app do + lane :distribute_app do |options| path = '../app/build.gradle' re = /versionCode\s+(\d+)/ @@ -28,19 +28,17 @@ platform :android do ) commit = last_git_commit - firebaseID = sh("$FIREBASE_APP_ID") firebase_app_distribution( - app: firebaseID, + app: options[:FIREBASE_APP_ID], groups: "internal, External", service_credentials_file: "reactnative-hms-a32ef61302c5.json", android_artifact_path: lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH], release_notes_file: "../ExampleAppChangelog.txt" ) - slackUrl = sh("$SLACK_URL") slack( message: ":react: 🎉 React Native Android App released! 🎊 :react:", - slack_url: slackUrl, + slack_url: options[:SLACK_URL], payload: { "📲 Download from Firebase 🤖" => "https://appdistribution.firebase.dev/i/7b7ab3b30e627c35", "📝 Changelog with Tickets" => File.read("../../ExampleAppChangelog.txt") diff --git a/packages/react-native-room-kit/example/ios/Gemfile.lock b/packages/react-native-room-kit/example/ios/Gemfile.lock index 784904e24..5fc46214b 100644 --- a/packages/react-native-room-kit/example/ios/Gemfile.lock +++ b/packages/react-native-room-kit/example/ios/Gemfile.lock @@ -8,8 +8,8 @@ GEM artifactory (3.0.15) atomos (0.1.3) aws-eventstream (1.2.0) - aws-partitions (1.834.0) - aws-sdk-core (3.185.1) + aws-partitions (1.843.0) + aws-sdk-core (3.185.2) aws-eventstream (~> 1, >= 1.0.2) aws-partitions (~> 1, >= 1.651.0) aws-sigv4 (~> 1.5) @@ -21,7 +21,7 @@ GEM aws-sdk-core (~> 3, >= 3.181.0) aws-sdk-kms (~> 1) aws-sigv4 (~> 1.6) - aws-sigv4 (1.6.0) + aws-sigv4 (1.6.1) aws-eventstream (~> 1, >= 1.0.2) babosa (1.0.4) claide (1.1.0) @@ -110,9 +110,9 @@ GEM google-apis-firebaseappdistribution_v1 (~> 0.3.0) fastlane-plugin-versioning (0.5.2) gh_inspector (1.1.3) - google-apis-androidpublisher_v3 (0.50.0) + google-apis-androidpublisher_v3 (0.51.0) google-apis-core (>= 0.11.0, < 2.a) - google-apis-core (0.11.1) + google-apis-core (0.11.2) addressable (~> 2.5, >= 2.5.1) googleauth (>= 0.16.2, < 2.a) httpclient (>= 2.8.1, < 3.a) @@ -166,7 +166,7 @@ GEM os (1.1.4) plist (3.7.0) public_suffix (5.0.3) - rake (13.0.6) + rake (13.1.0) representable (3.2.0) declarative (< 0.1.0) trailblazer-option (>= 0.1.1, < 0.2.0) @@ -221,4 +221,4 @@ DEPENDENCIES fastlane-plugin-versioning BUNDLED WITH - 2.4.13 + 2.4.21 diff --git a/release-apps.sh b/release-apps.sh index 47ece98c2..726173d09 100644 --- a/release-apps.sh +++ b/release-apps.sh @@ -6,12 +6,11 @@ set -x perform_npm_actions() { cd packages/react-native-hms + npm install cd ../react-native-room-kit - # git pull --verbose - npm install cd ./example @@ -24,9 +23,9 @@ release_android() { bundle install --verbose - fastlane add_plugin firebase_app_distribution + cat $FIREBASE_APP_ID - bundle exec fastlane distribute_app + bundle exec fastlane distribute_app FIREBASE_APP_ID: $FIREBASE_APP_ID SLACK_URL: $SLACK_URL } release_iOS() { From f1939b6df5829b00fdf5ddbce2cfc214a45c058d Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Fri, 3 Nov 2023 20:04:55 +0530 Subject: [PATCH 32/34] updated env variables --- .github/workflows/release-apps.yml | 5 +++-- release-apps.sh | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release-apps.yml b/.github/workflows/release-apps.yml index 24cb5ed71..c31fb5a97 100644 --- a/.github/workflows/release-apps.yml +++ b/.github/workflows/release-apps.yml @@ -48,8 +48,6 @@ jobs: - name: Setup Fastlane env: REACT_NATIVE_HMS_JSON: ${{ secrets.REACT_NATIVE_HMS_JSON }} - FIREBASE_APP_ID: ${{ secrets.FIREBASE_APP_ID }} - SLACK_URL: ${{ secrets.SLACK_URL }} IOS_APPFILE: ${{ secrets.IOS_APPFILE }} IOS_FASTFILE: ${{ secrets.IOS_FASTFILE }} IOS_PLUGINFILE: ${{ secrets.IOS_PLUGINFILE }} @@ -75,4 +73,7 @@ jobs: pwd ls -la - name: Run Release Script + env: + FIREBASE_APP_ID: ${{ secrets.FIREBASE_APP_ID }} + SLACK_URL: ${{ secrets.SLACK_URL }} run: sh release-apps.sh diff --git a/release-apps.sh b/release-apps.sh index 726173d09..a81db1a0a 100644 --- a/release-apps.sh +++ b/release-apps.sh @@ -5,6 +5,9 @@ set -e set -x perform_npm_actions() { + + cat $FIREBASE_APP_ID + cd packages/react-native-hms npm install @@ -23,8 +26,6 @@ release_android() { bundle install --verbose - cat $FIREBASE_APP_ID - bundle exec fastlane distribute_app FIREBASE_APP_ID: $FIREBASE_APP_ID SLACK_URL: $SLACK_URL } From 5937ebbadffdfacca2f6c2cfdfc6b870c4a36c97 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Fri, 3 Nov 2023 20:06:25 +0530 Subject: [PATCH 33/34] removed cat --- release-apps.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/release-apps.sh b/release-apps.sh index a81db1a0a..a7d1c149a 100644 --- a/release-apps.sh +++ b/release-apps.sh @@ -6,8 +6,6 @@ set -x perform_npm_actions() { - cat $FIREBASE_APP_ID - cd packages/react-native-hms npm install From 6c13d4b9864feb7acf748aa92e83c208b97c8ae5 Mon Sep 17 00:00:00 2001 From: Yogesh Singh Date: Sat, 18 Nov 2023 12:56:43 +0530 Subject: [PATCH 34/34] updated readme --- packages/react-native-hms/README.md | 5 +++++ packages/react-native-room-kit/README.md | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/packages/react-native-hms/README.md b/packages/react-native-hms/README.md index 296b43ed3..903bf28bb 100644 --- a/packages/react-native-hms/README.md +++ b/packages/react-native-hms/README.md @@ -22,6 +22,11 @@ With support for HLS and RTMP Live Streaming and Recording, Picture-in-Picture ( 📖 Read the Complete Documentation here: https://www.100ms.live/docs/react-native/v2/foundation/basics +| Package | Version | +| -------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------- | +| @100mslive/react-native-room-kit | [![npm](https://img.shields.io/npm/v/@100mslive/react-native-room-kit)](https://www.npmjs.com/package/@100mslive/react-native-room-kit) | +| @100mslive/react-native-hms | [![npm](https://img.shields.io/npm/v/@100mslive/react-native-hms)](https://www.npmjs.com/package/@100mslive/react-native-hms) | + ## 🏃 Example App 📲 Download the Example iOS app here: https://testflight.apple.com/join/v4bSIPad diff --git a/packages/react-native-room-kit/README.md b/packages/react-native-room-kit/README.md index dc8deda6c..c1b2ef472 100644 --- a/packages/react-native-room-kit/README.md +++ b/packages/react-native-room-kit/README.md @@ -22,6 +22,12 @@ With support for HLS and RTMP Live Streaming and Recording, Picture-in-Picture ( 📖 Read the Complete Documentation here: https://www.100ms.live/docs/react-native/v2/foundation/basics +| Package | Version | +| -------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------- | +| @100mslive/react-native-room-kit | [![npm](https://img.shields.io/npm/v/@100mslive/react-native-room-kit)](https://www.npmjs.com/package/@100mslive/react-native-room-kit) | +| @100mslive/react-native-hms | [![npm](https://img.shields.io/npm/v/@100mslive/react-native-hms)](https://www.npmjs.com/package/@100mslive/react-native-hms) | + + ## 🏃 Example App 📲 Download the Example iOS app here: https://testflight.apple.com/join/v4bSIPad