Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering incorrect credentials causes block to get stuck on the credential entering view #56

Open
helen opened this issue Jun 26, 2020 · 2 comments
Labels
help wanted Extra attention is needed type:bug Something isn't working.

Comments

@helen
Copy link
Contributor

helen commented Jun 26, 2020

Describe the bug
If you enter incorrect credentials in the block and save them, if you then correct them and save the block will not switch over to the map view. The credentials do save, so a current workaround is to refresh the screen.

Steps to Reproduce

  1. Enter incorrect credentials that pass the validation (10 characters for team and key IDs, with the header/footer text for the private key).
  2. Save and see that it remains on the credential form, which is expected.
  3. Change the credentials to be valid.
  4. Save and see that it still remains on the credential form, which is not expected.
  5. Refresh and see that the map view now works, indicating that your credentials were saved even though nothing happened.

Expected behavior
I would expect it to switch to the map after entering correct credentials :)

Additional context
This is in the console: [MapKit] mapkit.init(): already initialized; ignoring.. In brief discussions, it seems we need to approach this by destroying the mapkit object and then re-initializing.

@helen helen added the type:bug Something isn't working. label Jun 26, 2020
@helen helen added this to the 1.0.1 milestone Jun 26, 2020
@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jun 26, 2020
@jeffpaul
Copy link
Member

Punting this to the next release so we can wrap things up on version 1.0.1 and get this release out alongside WordPress 5.5 and the Block Directory.

@jeffpaul jeffpaul modified the milestones: 1.0.1, 1.1.0 Aug 10, 2020
@joshuaabenazer joshuaabenazer self-assigned this Sep 30, 2021
@joshuaabenazer
Copy link
Contributor

Spent some time trying to reinitialize or destroy the object, but wasn't able to find much help regarding this in the documentation. Played around a bit too, but this doesn't seem straightforward enough to destroy.

Also noticed the check on the configuration settings page requires a page refresh for re-checking the authorization.
There seems to be some optimization that can be done around the callbacks, but I would suggest we direct the user to the configuration settings page instead, as a temp solution till we can figure this out.

@joshuaabenazer joshuaabenazer removed their assignment Oct 1, 2021
@jeffpaul jeffpaul moved this to To Do in Open Source Practice Oct 14, 2021
@jeffpaul jeffpaul modified the milestones: 1.0.2, 1.1.0 Dec 11, 2021
@jeffpaul jeffpaul modified the milestones: 1.1.0, Future Release Jun 28, 2022
@jeffpaul jeffpaul moved this from To Do to Backlog in Open Source Practice Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

3 participants