Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0.1 is not available on Packagist #241

Closed
thomasfw opened this issue Jan 17, 2024 · 5 comments · Fixed by #242
Closed

v1.0.1 is not available on Packagist #241

thomasfw opened this issue Jan 17, 2024 · 5 comments · Fixed by #242
Assignees
@unfulvio-godaddy
Labels
Bug Bug report or pull requests that addresses a bug Dependencies Items related to Composer dependencies

Comments

@thomasfw
Copy link

thomasfw commented Jan 17, 2024 •
edited
Loading

Bug report

v1.0.1 is not available on Packagist - https://packagist.org/packages/10up/wp_mock

Replication steps

N/A

Expected behavior

N/A

Logs 

Problem 1
    - Root composer.json requires 10up/wp_mock ^1.0.1, found 10up/wp_mock[dev-refactor/move-hooks-component-in-own-namespace, dev-trunk, 0.1.0, ..., 0.5.0, 1.0.0] but it does not match the constraint.

Screenshots

N/A
@unfulvio-godaddy
Copy link
Member

hey @thomasfw you are absolutely right, looks like we forgot to update composer.json version in the last rollout; however, the version in composer.json may not be required and perhaps we could drop it altogether to avoid this type of issue in the future

in the meantime this is fixed you could use dev-trunk as 1.0.1 in your composer dependency version; it would load the current main branch which is up to date to 1.0.1 (we haven't pushed new code since so it should be alright)

@unfulvio-godaddy unfulvio-godaddy mentioned this issue Jan 19, 2024
Merged
9 tasks
@unfulvio-godaddy unfulvio-godaddy self-assigned this Jan 19, 2024
@unfulvio-godaddy unfulvio-godaddy added Bug Bug report or pull requests that addresses a bug Dependencies Items related to Composer dependencies labels Jan 19, 2024
@thomasfw
Copy link
Author

No problem, will use dev-trunk for now - thanks

unfulvio-godaddy added a commit that referenced this issue Jan 22, 2024
@unfulvio-godaddy
Remove version from composer and update changelog.md (#242)
48b7f22 
# Summary <!-- Required -->

Removes package version from composer.json. This should make packagist
point to the git tags. Also updated the changelog.md to include changes
from 1.0.1.

### Closes: #241 

## Contributor checklist <!-- Required -->

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you are unsure about any of these, please ask for
clarification. We are here to help! -->

- [x] I agree to follow this project's [**Code of
Conduct**](https://github.com/10up/.github/blob/trunk/CODE_OF_CONDUCT.md).
- [x] I have updated the documentation accordingly 
- [x] I have added tests to cover changes introduced by this pull
request
- [x] All new and existing tests pass

## Testing <!-- Required -->

- [x] All tests pass in CI 

### Reviewer checklist <!-- Required -->

<!-- The following checklist is for the reviewer: add any steps that may
be relevant while reviewing this pull request -->

- [x] Code changes review
- [x] Documentation changes review
- [x] Unit tests pass
- [x] Static analysis passes
@thomasfw
Copy link
Author

thomasfw commented Jan 22, 2024 •
edited
Loading

Can I ask whether you'll be tagging a new release with the fix in 48b7f22, or will this be included in a later version?

Edit: I should add that this isn't fixed until a new version is tagged, otherwise packagist won't pick up the changes. The package remains incompatible with PHP 8.3.1 when installing with composer (@unfulvio-godaddy)

@unfulvio-godaddy unfulvio-godaddy mentioned this issue Mar 12, 2024
Closed
8 tasks
@BrianHenryIE
Copy link
Contributor

Looks like that is on Packagist now. You can configure a webhook from GitHub to Packagist to run on tags. It's very easy to set up but I see a comment that you don't have full access to Packagist to do that. Still, Packagist polls GitHub to look for updates too.

In the Composer documentation it says:

In most cases [version] is not required and should be omitted [from composer.json]

So I think the problem was correctly fixed with #242, and that #244 should not be implemented.

@unfulvio-godaddy
Copy link
Member

indeed it wasn't needed all I had to do is to republish the package here (dropping the composer version happened after we tagged 1.0.1); so retagged using the latest from trunk (which only contained the version drop from composer) and that fixed it in Packagist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unfulvio-godaddy unfulvio-godaddy

Labels
Bug Bug report or pull requests that addresses a bug Dependencies Items related to Composer dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove version from composer and update changelog.md 10up/wp_mock
3 participants
@BrianHenryIE @thomasfw @unfulvio-godaddy