Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review "Open Badges API" Section #333

Open
1 task
Tracked by #352
amiller-ims opened this issue Feb 3, 2022 · 3 comments
Open
1 task
Tracked by #352

Review "Open Badges API" Section #333

amiller-ims opened this issue Feb 3, 2022 · 3 comments
Assignees
Labels

Comments

@amiller-ims
Copy link
Collaborator

amiller-ims commented Feb 3, 2022

This issue was created to capture a discussion of the OB 3.0 API.

The draft 3.0 API in the base document is an update to the BadgeConnect API™ defined in [OB-21]. It was designed with these goals:

  • Keep the [OB-21] style of API in the base document (also adopted by [CLR-10]) with payload modifications as necessary.
  • Update the security parts to conform with the IMS Security Framework 1.1.

Reviewer Tasks

@amiller-ims amiller-ims added the 3p0 label Feb 3, 2022
@justinpitcher
Copy link
Contributor

Related to #352 IMS Base Document

@amiller-ims amiller-ims mentioned this issue Mar 9, 2022
16 tasks
@amiller-ims amiller-ims changed the title OB 3.0: Review API design Review "Open Badges API" Section Mar 16, 2022
@amiller-ims
Copy link
Collaborator Author

For those of you looking at the API, the CLR version is a little further ahead: https://www.imsglobal.org/spec/clr/v2p0#api (you need to be logged in to see this document). In particular, section 5.3 REST Endpoints is generated from a new (in progress) ServiceModel in the clr_v2p0.lines file. I renamed the REST endpoint to ims/clr/v2p0/credentials (was .../clrs in CLR 1.0). And I think it could be ims/ob/v3p0/credentials in OB. I initially experimented with using a VP for the response payload, but it got WAY too complicated trying to handle both CompactJws (VC-JWT proof) and JSON (LDS proofs) formats, and ended up using a GetCredentialsResponse class.

The two VC APIs that have traction are W3C VC-API and DIF OIDC API. Both are centered around issuing and verifying credentials. While the CLR 1.0 and OB 2.1 APIs are built around moving credentials that have already been issued, and assume the entity that has the credential will do their own verifying. I think there is a place for the CLR 1.0/OB 2.1 style API and the emerging VC APIs. I don't think we should abandon the CLR 1.0/OB 2.1 style APIs.

@xaviaracil
Copy link
Collaborator

@kayaelle @ottonomy Since the spec is already in Candidate Final, is it ok to close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants