Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Travis CI builds #20

Open
23maverick23 opened this issue May 17, 2018 · 1 comment
Open

Review Travis CI builds #20

23maverick23 opened this issue May 17, 2018 · 1 comment

Comments

@23maverick23
Copy link
Owner

Travis CI builds for 2.7 and 3.5 are failing for two reasons:

  1. String comparisons of tostring() and prettify()

There doesn't seem to be a reliable way to compare XML strings with multiple elements across python versions as the elements can be in a random order.

  1. IsInstance() comparisons

This might not even be a necessary test, so look into this

@SupreetBose
Copy link

xml_req = connections.Request(app, auth, xml_data).tostring()
Above line is giving error as below :
TypeError: can only concatenate str (not "bytes") to str
I am using Py 3.9 how should I proceed ? If I remove tostring from xml_req then I get the below error
TypeError: message_body should be a bytes-like object or an iterable, got <class 'oaxmlapi.connections.Request'>
My code that I used is as below to convert 2.7 to 3
req = urllib.request.Request(url='Url Path', data=xml_req)
response = urllib.request.urlopen(req)
html = response.read()
print(html)

Any thoughts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants