Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master] - PROD-210: Add INVITE format to strip + #6512

Merged
merged 12 commits into from
May 1, 2020
Merged

[Master] - PROD-210: Add INVITE format to strip + #6512

merged 12 commits into from
May 1, 2020

Conversation

mk1s
Copy link
Contributor

@mk1s mk1s commented Apr 30, 2020

This PR adds a new knm_converter and schema to allow an INVITE format to the prefixed + plus stripped.

knm_converters:

This PR adds and exports new converter strip_plus and is_strip_plus functions from the converter abstraction.

knm_converter_regex:

Implements the to_strip_plus function for use by knm_converters abstraction.

knm_converter_migrate_maintenance

Creates a maintenance command to migrate existing devices, resources, and trunks configured for a given invite format to another.

The default for migrate/0 converts from npan to strip_plus.

Related PRs:

John White added 9 commits May 1, 2020 09:07
- Add to_strip_plus and is_strip_plus to knm_converters abstraction

- Add to_strip_plus stub to th knm_regex_converter
- Add strip_plus converter case to ecallmgr

- Add strip_plus converter case to kapps_call_command

- Add strip_plus converter to kz_directory_endpoints

- Add strip_plus converter to kz_endpoints

- Remove extraneous comment from regex_converter
@mk1s mk1s marked this pull request as ready for review May 1, 2020 15:22
@icehess icehess merged commit 8030b05 into master May 1, 2020
@icehess icehess deleted the PROD-210 branch May 1, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants