Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great image, would you consider adding support for custom modules? #3

Open
virtuman opened this issue Nov 30, 2016 · 1 comment
Open

Comments

@virtuman
Copy link

Awesome image, thank you for sharing.

Would you consider adding support for a couple of things to this:

  1. LDAP module, similar to this one here: https://hub.docker.com/r/virtuman/docker-nginx/~/dockerfile/
  2. not sure if anyone ever uses or if anyone would benefit from this, but generally a good module: nginx_upload_progress
  3. virtual host stats: nginx-module-vts
  4. with-http_geoip_module
  5. with-http_image_filter_module
  6. with-libatomic
  7. with-http_image_filter_module
  8. possibly add an Environment variable to append to ./configure statement, ie. $ADDITIONAL_CONFIGURE_PARAMETERS

some of the modules support dynamic loading (like geoip).

here's a very good implementation of dynamic modules:
https://github.com/ngineered/nginx-php-fpm/blob/master/Dockerfile
combination of both of these image builders would create and ultimate nginx image

Thank you for consideration

@27Bslash6
Copy link
Owner

Thanks for your comments. I'm definitely open to suggestions about useful modules for the build, while at the same time trying not to go crazy with cruft.

The currently installed modules are only those which I find regular use for. If you would like to create pull requests for modules you find particularly useful, along with supporting arguments then I will definitely consider adding them to the Dockerfiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants