Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of Three.js (website broken) #3

Open
trusktr opened this issue Feb 23, 2021 · 2 comments
Open

Pin version of Three.js (website broken) #3

trusktr opened this issue Feb 23, 2021 · 2 comments

Comments

@trusktr
Copy link

trusktr commented Feb 23, 2021

Hello, you used a non-versioned source for Three.js, so when they release breaking changes it breaks the app.

Do you mind updating to use a versioned Three.js source?

One way is to install a specific version with npm, and load it from local node_modules rather than from threejs.org.

Another way is to use unpkg (CDN for NPM), and you can load a versioned URL like this one: https://unpkg.com/[email protected]/build/three.min.js

Then this way, the site won't break because it will always use the same version of Three.js until you manually update it.

@trusktr
Copy link
Author

trusktr commented Feb 23, 2021

Sidenote, even https://www.3dmeshviewer.com/demo is broken because of this.

@trusktr
Copy link
Author

trusktr commented Feb 23, 2021

Just replace all https://threejs.org occurrences in script tag URLs in the HTML files with https://unpkg.com/[email protected] where X.X.X is the version you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant