Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Upgrade to CentOS stream9 #3866

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

[WIP] Upgrade to CentOS stream9 #3866

wants to merge 20 commits into from

Commits on Aug 12, 2024

  1. Configuration menu
    Copy the full SHA
    242f8ee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3bde849 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    617a5f9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    24c7163 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ba7991c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9718acc View commit details
    Browse the repository at this point in the history
  7. Fix decorators by making methods non-private

    The issue was caused by `draper` gem upgrade (which was a result of
    upgrading Ruby to v3). The issue was here:
    https://github.com/drapergem/draper/blob/v4.0.2/lib/draper/automatic_delegation.rb#L10-L26
    
    In decorators we delegate all methods to the decorated object. But this version of the library
    only does that when there is no private method with the same name on the decorator.
    In this case, as `admin_user`  was a private method on AccountDecorator, draper tried to call
    `admin_user `on superclass, but it was not there, so it was failing with:
    ```
    ActionView::Template::Error (super: no superclass method `admin_user' for #<AccountDecorator:0x00007f8784266d18
      @object=#<Account id: 11, org_name: "Testing" ...> Did you mean? admin_user_email):
    ```
    
    Removing it from `private_methods` fixed the issue.
    mayorova committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e58f641 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    75485e7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    198f889 View commit details
    Browse the repository at this point in the history
  10. Skip the test using fibers

    This test caused multiple tests fail with:
    ```
    ThreadError: deadlock; lock already owned by another fiber belonging to the same thread
    ```
    
    This is fixed in Rails 7.0.6 and higher: rails/rails#46553
    mayorova committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    53090d7 View commit details
    Browse the repository at this point in the history
  11. Fix deprecation warning for fixture_file_upload

    ```
    DEPRECATION WARNING: Passing a path to `fixture_file_upload` relative to `fixture_path` is deprecated.
    In Rails 7.0, the path needs to be relative to `file_fixture_path`.
    
    Please modify the call from
    `fixture_file_upload("wide.jpg")` to `fixture_file_upload("../../../test/fixtures/wide.jpg")`.
     (called from block (4 levels) in <main> at /home/dmayorov/Projects/3scale/porta/spec/acceptance/api/cms_file_spec.rb:24)
    ```
    mayorova committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    da9a77c View commit details
    Browse the repository at this point in the history
  12. Remove URL hacks for Liquid

    mayorova committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    9319395 View commit details
    Browse the repository at this point in the history
  13. Remove an unused Dockerfile

    mayorova committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b1d7bbc View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    807328c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5740cdd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f9d56fd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5979735 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9d27471 View commit details
    Browse the repository at this point in the history
  6. Use Chrome version 126

    mayorova committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d7135cd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4707fc5 View commit details
    Browse the repository at this point in the history