-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade to CentOS stream9 #3866
Draft
mayorova
wants to merge
20
commits into
master
Choose a base branch
from
ruby-3.1-stream9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Aug 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 242f8ee - Browse repository at this point
Copy the full SHA 242f8eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3bde849 - Browse repository at this point
Copy the full SHA 3bde849View commit details -
Configuration menu - View commit details
-
Copy full SHA for 617a5f9 - Browse repository at this point
Copy the full SHA 617a5f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24c7163 - Browse repository at this point
Copy the full SHA 24c7163View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba7991c - Browse repository at this point
Copy the full SHA ba7991cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9718acc - Browse repository at this point
Copy the full SHA 9718accView commit details -
Fix decorators by making methods non-private
The issue was caused by `draper` gem upgrade (which was a result of upgrading Ruby to v3). The issue was here: https://github.com/drapergem/draper/blob/v4.0.2/lib/draper/automatic_delegation.rb#L10-L26 In decorators we delegate all methods to the decorated object. But this version of the library only does that when there is no private method with the same name on the decorator. In this case, as `admin_user` was a private method on AccountDecorator, draper tried to call `admin_user `on superclass, but it was not there, so it was failing with: ``` ActionView::Template::Error (super: no superclass method `admin_user' for #<AccountDecorator:0x00007f8784266d18 @object=#<Account id: 11, org_name: "Testing" ...> Did you mean? admin_user_email): ``` Removing it from `private_methods` fixed the issue.
Configuration menu - View commit details
-
Copy full SHA for e58f641 - Browse repository at this point
Copy the full SHA e58f641View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75485e7 - Browse repository at this point
Copy the full SHA 75485e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 198f889 - Browse repository at this point
Copy the full SHA 198f889View commit details -
This test caused multiple tests fail with: ``` ThreadError: deadlock; lock already owned by another fiber belonging to the same thread ``` This is fixed in Rails 7.0.6 and higher: rails/rails#46553
Configuration menu - View commit details
-
Copy full SHA for 53090d7 - Browse repository at this point
Copy the full SHA 53090d7View commit details -
Fix deprecation warning for
fixture_file_upload
``` DEPRECATION WARNING: Passing a path to `fixture_file_upload` relative to `fixture_path` is deprecated. In Rails 7.0, the path needs to be relative to `file_fixture_path`. Please modify the call from `fixture_file_upload("wide.jpg")` to `fixture_file_upload("../../../test/fixtures/wide.jpg")`. (called from block (4 levels) in <main> at /home/dmayorov/Projects/3scale/porta/spec/acceptance/api/cms_file_spec.rb:24) ```
Configuration menu - View commit details
-
Copy full SHA for da9a77c - Browse repository at this point
Copy the full SHA da9a77cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9319395 - Browse repository at this point
Copy the full SHA 9319395View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1d7bbc - Browse repository at this point
Copy the full SHA b1d7bbcView commit details
Commits on Aug 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 807328c - Browse repository at this point
Copy the full SHA 807328cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5740cdd - Browse repository at this point
Copy the full SHA 5740cddView commit details -
Configuration menu - View commit details
-
Copy full SHA for f9d56fd - Browse repository at this point
Copy the full SHA f9d56fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5979735 - Browse repository at this point
Copy the full SHA 5979735View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d27471 - Browse repository at this point
Copy the full SHA 9d27471View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7135cd - Browse repository at this point
Copy the full SHA d7135cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4707fc5 - Browse repository at this point
Copy the full SHA 4707fc5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.