Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests around metadata & bundle checking #159

Open
2 tasks
ryanbourneuk opened this issue Jul 22, 2019 · 0 comments
Open
2 tasks

Add unit tests around metadata & bundle checking #159

ryanbourneuk opened this issue Jul 22, 2019 · 0 comments
Assignees
Labels
codable-refactor Work relating to the Storm Codable refactor

Comments

@ryanbourneuk
Copy link
Contributor

ryanbourneuk commented Jul 22, 2019

Expected Behaviour

Metadata & bundle validation should have unit test coverage.

Current Behaviour

There is no unit test coverage.

Possible Solution

  • Add #warnings around affected areas to direct where tests should be added.
  • Add new tests to clear #warnings

Steps to Reproduce (for bugs)

Context

As part of the codable-refactor project, parts of the codebase (mainly storm object related) will be migrated from using manual JSON parsing / initialisation to using Codable. However, as ThunderCloud is used in many many apps, it'd be great for it to not break. If we determine the current state of ThunderCloud to be as expected, we can write a test suite against it - and then migrate to use Codable. The tests will then inform us if we have deviated from the expected behaviour.

@ryanbourneuk ryanbourneuk self-assigned this Jul 22, 2019
@ryanbourneuk ryanbourneuk added the codable-refactor Work relating to the Storm Codable refactor label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codable-refactor Work relating to the Storm Codable refactor
Projects
None yet
Development

No branches or pull requests

1 participant