Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks when ordering of inclusions is different #1

Open
djay opened this issue Feb 2, 2021 · 5 comments
Open

Breaks when ordering of inclusions is different #1

djay opened this issue Feb 2, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@djay
Copy link

djay commented Feb 2, 2021

e.g.

        python-version: ['2.7']
        plone-version: 
          - '4.1'
          - '4.3'
          - '5.0'
          - '5.1'
          - '5.2'
        include:
          - plone-version: 5.2
            python-version: 3.7
          - plone-version: 5.2
            python-version: 3.8

ends up looking like

Screen Shot 2021-02-02 at 4 40 13 pm

@svetlyak40wt
Copy link
Member

Omg. Seems Github changes run's name when you are using include with different ordering.

I'll try to figure out some solution. As a workaround, you can change the ordering in the include list.

@svetlyak40wt svetlyak40wt added the bug Something isn't working label Feb 2, 2021
@djay
Copy link
Author

djay commented Feb 9, 2021

I changed the ordering and now nothing is appearing - https://github.com/collective/collective.pfg.signup

@svetlyak40wt
Copy link
Member

This is because your workflow has no runs:

$ curl 'https://api.github.com/repos/collective/collective.pfg.signup/actions/workflows/4346705/runs?branch=master'
{
  "total_count": 0,
  "workflow_runs": [

  ]
}

Don't know why this is happened. Probably GitHub deletes old runs. Or deletes runs when workflow matrix changes.

By the way, why do you ignore the master branch in the workflow? Don't you want to run tests for the master/release branches?

@svetlyak40wt
Copy link
Member

I've fixed rendering of the empty badge. Now it renders like that:

collective pfg signup

There are a number runs, but all of them belong to a branch pypi-release:

collective pfg signup action runs

I've added an ability to specify a branch for rendering the badge. For example, if the default branch is master, but there is also a pypi-release branch and you want to show the badge, corresponding to pypi-release branch, then you might to use this URL:

http://github-actions.40ants.com/collective/collective.pfg.signup/matrix.svg?branch=pypi-release

It will be rendered like this:

Note, an image is broken, because branch pypi-release does not exist anymore and my server is not able to fetch github workflow's content from this branch.

What you need to do now

Now you need:

  • to create a new release branch;
  • ensure the giithub action started for this branch;
  • edit README and add ?branch=the-branch-name to SVG url.

@djay
Copy link
Author

djay commented Feb 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants