Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #61

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Fix #61

merged 3 commits into from
Jul 24, 2024

Conversation

417-72KI
Copy link
Owner

No description provided.

@jagreenwood
Copy link

Maybe fix an issue I just encountered when using 5.10?

error: 'workspace': package 'workspace' is using Swift tools version 5.10.0 but the installed version is 5.9.2

Copy link

Messages
📖 SwiftLint: 0.55.1
📖 danger-js: 12.3.3
📖

danger-swift: 3.18.1
�[0;0m

📖

Swift version 5.10 (swift-5.10-RELEASE)
Target: x86_64-unknown-linux-gnu

📖 Validation passed! 🎉

Generated by 🚫 Danger Swift against 4039199

@417-72KI
Copy link
Owner Author

417-72KI commented Jul 24, 2024

@jagreenwood
I'm not sure where it's happening, but CI has not run for 2 months and will build with latest tools when this PR merged.

@417-72KI 417-72KI merged commit e28b130 into main Jul 24, 2024
6 checks passed
@417-72KI 417-72KI deleted the fix-building branch July 24, 2024 17:36
@jagreenwood
Copy link

@417-72KI I'm still seeing an error. Looks like the action is pulling the 5.9.2 docker image.

Screenshot 2024-07-24 at 2 34 46 PM

This is my workflow config

name: Run Danger
on:
  workflow_dispatch:
  pull_request:
    types:
      - opened
      - reopened
      - synchronize
      - ready_for_review
jobs:
  build:
    if: github.event.pull_request.draft == false
    name: "Run Danger"
    permissions:
      contents: write
      issues: write
      pull-requests: write
    runs-on: ubuntu-latest
    steps:
      - name: Git checkout
        uses: actions/checkout@v4
      - name: Danger
        uses: 417-72KI/[email protected]
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@jagreenwood
Copy link

jagreenwood commented Jul 24, 2024

Oh maybe because 5.9 in action.yml

image: 'docker://41772ki/danger-swiftlint:5.9'

@417-72KI 417-72KI mentioned this pull request Jul 25, 2024
@417-72KI
Copy link
Owner Author

@jagreenwood
Thank you for finding the reason and sorry for inconvinience.
I'm going to fix it now🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants