Fix: don't show initial label when backend state is not valid #24

42Cluster-Seoul · Apr 14, 2024 · 4e2fd71 · 4e2fd71
1 parent 4988bc1
commit 4e2fd71
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/public/app/features/dashboard/containers/DashboardSelect.tsx b/public/app/features/dashboard/containers/DashboardSelect.tsx
@@ -61,7 +61,7 @@ const DashboardSelect = () => {
           className={cx(gitHubButtonStyles.button, gitHubButtonStyles.basicButton, styles.button)}
           aria-label="New"
         >
-          <div className={styles.ellipsis}>{currDashboard}</div>
+          <div className={styles.ellipsis}>{backendState.isValid ? currDashboard : ''}</div>
         </ToolbarButton>
       </div>
     </Dropdown>

diff --git a/public/app/features/dashboard/containers/OptionSelect.tsx b/public/app/features/dashboard/containers/OptionSelect.tsx
@@ -19,7 +19,8 @@ interface Props {
 }
 
 const OptionSelect = ({ picker }: Props) => {
-  const dashboards = useSelector((state) => state.fourtyTwoClusterBackend).dashboards;
+  const backendState = useSelector((state) => state.fourtyTwoClusterBackend);
+  const dashboards = backendState.dashboards;
   const [isOpen, setIsOpen] = useState(false);
   const gitHubButtonStyles = useStyles2(GitHubButtonStyles);
   const styles = useStyles2(getStyles);
@@ -77,7 +78,7 @@ const OptionSelect = ({ picker }: Props) => {
         className={cx(gitHubButtonStyles.button, gitHubButtonStyles.greenButton)}
         aria-label="New"
       >
-        <div className={styles.ellipsis}>{currSubCategory}</div>
+        <div className={styles.ellipsis}>{backendState.isValid ? currSubCategory : ''}</div>
       </ToolbarButton>
     </Dropdown>
   );