[#17] Switch releasing to micro-common-release #26
Conversation
szpak
changed the title
szpak
force-pushed
the
issues/17-commonRelease
branch
from
9b8b192 to
9297105
Compare
|
Why removing the package scope stuff? Other than that +1 |
|
BTW maybe we should release 2.0.0 once we merge this? |
Groovy 2.3 seems to be more restrictive (unfortunately only at a class level) and several tests fail in runtime due to wrong class scope. An alternative is to move tests to the same package (someone with wide code base knowledge would be better to do that).
I was thinking about that same - easier for people to choose version. In addition it would be easier to release a version 1.x with critical issue fix (if needed). |
| def "should not fail or display excluded versions for dependencies found in external repo"() { | ||
| given: | ||
| artifactMetadataRequestResponse('org.hibernate', 'hibernate-core', new SimpleTemplateEngine().createTemplate(RESPONSE_TEMPLATE).make([artifactVersion: artifactVersion]).toString()) | ||
| project.extensions.uptodate.versionToExcludePatterns = [ALPHA, BETA, RC, CR, SNAPSHOT] | ||
| project.extensions.uptodate.setExcludedVersionPatterns(ALPHA, BETA, RC, CR, SNAPSHOT) |
There was a problem hiding this comment.
There is something strange with those tests. versionToExcludePatterns was removed in 1.1.0, but they passed before I upgraded Groovy to 2.3.
szpak
force-pushed
the
issues/17-commonRelease
branch
from
9297105 to
7b5bde1
Compare
|
What are we waiting for here? :D |
That required more deeply changes: - switch to Gradle 2.x (drop support for projects with Gradle 1.x) - switch to Groovy 2.3.x - upgrade Spock to 1.0 - upgrade other dependencies For release instructions see: https://github.com/4finance/micro-common-release/wiki
szpak
force-pushed
the
issues/17-commonRelease
branch
from
7b5bde1 to
dfd7632
Compare
That required more deeply changes:
For release instructions see:
https://github.com/4finance/micro-common-release/wiki
Note. it is quite possible that there are still issues in proposed new release mechanism. It will be tested by the next release of the plugin.
It fixes #17.