Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reloading of plugins #8

Open
5HT2 opened this issue Apr 9, 2022 · 0 comments
Open

Hot reloading of plugins #8

5HT2 opened this issue Apr 9, 2022 · 0 comments

Comments

@5HT2
Copy link
Owner

5HT2 commented Apr 9, 2022

This is totally doable, my only concerns lie with the Docker version

  • I want plugins to not be reliant on http-bash-requests (for obvious reasons).
  • Calling os.Exec from Docker would theoretically work, but this poses new problems
    • The Dockerfile is mounting the config dir to /taro-files, which only contains the config folder
    • /taro-bot contains a copy of files in the image
    • We want to allow the mounted folder to be git pulled to allow easy updates, without fucking up user-level permissions when Docker is run as root

I propose mounting the entire directory taro is built from, and moving config there? Rather than keeping a second mount for config.
You're already intended to build taro yourself, as I don't provide prebuilt images, so keeping a copy of the git repo to allow plugin updates would be entirely optional but required for git pulling plugins.

@5HT2 5HT2 added the enhancement New feature or request label Apr 9, 2022
@5HT2 5HT2 added this to the 1.7.0 milestone Apr 9, 2022
@5HT2 5HT2 added the plugin label Apr 10, 2022
@5HT2 5HT2 mentioned this issue May 1, 2022
@5HT2 5HT2 modified the milestones: 1.7.0, 1.8.0 May 23, 2022
@5HT2 5HT2 added plugin framework and removed plugin enhancement New feature or request labels May 28, 2022
@5HT2 5HT2 modified the milestones: 1.8.0, 1.9.0 Jun 9, 2022
@5HT2 5HT2 modified the milestones: 1.9.0, 1.10.0 Jun 21, 2022
@5HT2 5HT2 modified the milestones: 1.11.0, 1.12.0 Jul 21, 2022
@5HT2 5HT2 modified the milestones: 1.13.0, 1.14.0 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant