Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InvalidProxyContract #100

Open
germartinez opened this issue Aug 7, 2020 · 0 comments
Open

InvalidProxyContract #100

germartinez opened this issue Aug 7, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@germartinez
Copy link
Member

Situation locally / in Travis

The CPK tests uses the cpk-test branch of the Safe Relay Service, which has this conditions commented:
https://github.com/gnosis/safe-relay-service/blob/cpk-test/safe_relay_service/relay/services/transaction_service.py#L388

This is necessary because the apps are sharing the same Ganache instance and they need to deploy all the contracts needed.

Situation in production (checked on Rinkeby)

The CPK uses the Safe Relay Service in production and this exception is thrown:
https://github.com/gnosis/safe-relay-service/blob/master/safe_relay_service/relay/services/transaction_service.py#L392

The proxy contract deployed by the CPKFactory.sol should be recognized as valid by the Safe Relay Service because the official Safe contracts are used (https://github.com/gnosis/contract-proxy-kit/blob/master/contracts/CPKFactory.sol#L4-L5) but somehow is not taken as a valid one.

@germartinez germartinez added the bug Something isn't working label Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant