Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deep links to let the user open 5calls.org pages in the Android app. #100

Open
dektar opened this issue Sep 24, 2017 · 4 comments
Open

Comments

@dektar
Copy link
Collaborator

dektar commented Sep 24, 2017

https://developer.android.com/training/app-links/index.html

Users could go directly to the issues page if they get a link to a particular issue. This would allow them to log calls within the app so that all their call stats are in one place.

Low priority.

@nickoneill Curious what you think of this.

@nickoneill
Copy link
Member

I am really into this! Planning on doing something similar on iOS as well so I'm glad we can support on both platforms. I'm not completely familiar with the experience on android, I will try to find an app that implements this to check it out on my tablet.

@dektar
Copy link
Collaborator Author

dektar commented Sep 26, 2017

Cool! How do you plan to handle issues that are no longer active -- is there a way for apps to load up that JSON anyway? (How are these handled on the site?)

@nickoneill
Copy link
Member

We refresh all the issues and check to see if the issue you navigated to is in that list. Otherwise, we show a "this isn't isn't relevant anymore" message like here: https://5calls.org/issue/asd (also, whoops, I guess we have to fix that email link).

I can pretty quickly wire up something that will return a single issue for an issue id if that is easier for you, but we don't want people calling about these issues that are no longer active so we'd have to remove the contacts section at the very least.

@herrold
Copy link

herrold commented Sep 26, 2017

The MailTo on that sample page is empty, and raw HTML is exposed

This should be detected, and when there is a missing field, an error raised, and the MailTo supressed, in page generation

I am not immediately sure how to attach a screen shot so I placed one at:

http://gallery.herrold.com/stuff/5calls-PII-in-flight.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants