-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monster languages should be NamedAPIResource #272
Comments
Good shout out! I think that makes a lot of sense! |
So, this also falls into a similar issue with While the latter could benefit from the choice structure, the former is a bit more complicated. Here is a list of all of the ways that language will not fall into an easy structure like this:
|
A way that we could potentially handle this is turn the string into a list of entries. All of the ones that have a corresponding language we could use the APIReference structure. And the rest stay as just a string in the list. Not sure how best to handle |
An array of entries is a sound idea, but perhaps rather than each entry being either a string or a reference, the array (for "Blink Dog, understands Sylvan but can't speak it") could look something more like: [
{
"name": "Blink Dog"
},
{
"name": "Sylvan",
"references": {
"index": "sylvan",
"name": "Sylvan",
"url": "/api/languages/sylvan"
},
"passive": true
}
] Here
Whatever we settle on, preserving the source text as a separate attribute is definitely a good call. |
The key "languages" is inconsistent across the API and so either the monster languages should be NamedAPIResources or perhaps changed to a different key (maybe "communication").
The text was updated successfully, but these errors were encountered: