Skip to content

Commit

Permalink
보일러플레이트 빌드시 에러 해결 및 PR 템플릿 수정 (#4)
Browse files Browse the repository at this point in the history
* Feat: PR, Issue 템플릿

* Fix: 보일러플레이트 수정-빌드에러 해결

* Feat: PR 템플릿 명세 추가
  • Loading branch information
Eugene-A-01 authored Jan 18, 2024
1 parent db41a31 commit a717970
Show file tree
Hide file tree
Showing 6 changed files with 9,478 additions and 3,031 deletions.
14 changes: 10 additions & 4 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,24 @@
## 개요

-
- 개요는 변경 사항 및 관련 이슈에 대해 간단하게 작성해주세요.
- 해당 PR에 대한 리뷰어와 라벨을 생성해 주세요.

<br>

## 작업 사항

-
-
-
-

<br>

## 참고 사항 (optional)

-
- 작업 중 만난 버그, 구현 과정 중 어려움, 고민
- 해결 방법
- 해당 라이브러리를 선택한 이유
- 테스트 계획

<br>

Expand All @@ -26,6 +32,6 @@

## 리뷰어에게

-
- 어떤 부분에 리뷰어가 집중하면 좋을지

<br>
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@
"@tanstack/react-query": "^5.17.12",
"@tanstack/react-query-devtools": "^5.17.12",
"@vanilla-extract/integration": "^6.2.4",
"@vanilla-extract/next-plugin": "^2.3.2",
"axios": "^1.6.5",
"next": "14.0.4",
"react": "^18",
"react-dom": "^18",
"react-scripts": "^5.0.1",
"zustand": "^4.4.7"
},
"devDependencies": {
Expand Down
1 change: 0 additions & 1 deletion src/app/(BeforeLogin)/layout.tsx

This file was deleted.

3 changes: 3 additions & 0 deletions src/app/(BeforeLogin)/login/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default function Login() {
return <div>로그인페이지</div>;
}
8 changes: 8 additions & 0 deletions src/app/layout.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
"use client";

import React from "react";
import { ReactNode } from "react";

export default function TempLayout({ children }: { children: ReactNode }) {
return <div>{children}</div>;
}
Loading

0 comments on commit a717970

Please sign in to comment.