Feat: 탐색 페이지 퍼블리싱, 데이터 바인딩 (임시) #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yWave-front into feature/list-detail-outer
auto-assign
bot
requested review from
Eugene-A-01,
kanglocal and
ParkSohyunee
|
@Nahyun-Kang is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
ParkSohyunee
approved these changes
Feb 11, 2024
Comment on lines
+58
to
+66
| export interface ListItemsType { | ||
| id: number; | ||
| rank: number; | ||
| title: string; | ||
| comment: string; | ||
| link: string; | ||
| imageUrl: string; | ||
| } | ||
|
|
There was a problem hiding this comment.
나현님 이부분만 나중에 합친 PR올리실 때, 기존에 있는 타입(ItemType)을 사용하면 될 것 같습니다!
+. 나현님 아이템 부분이랑 피드페이지 아이템 부분 켭치는 부분이 있어서 타입 작업하실때 타입 같이 보면 좋을 것 같습니당~!!
There was a problem hiding this comment.
앗 그렇군요..! 생각해보니 겹치는 타입이 많을 것 같네용...👀 이후에 PR 합칠 때 기존에 만들어두신 타입 사용해보겠습니당!!🤩
Nahyun-Kang
changed the title
Eugene-A-01
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항 (optional)
관련 이슈 (optional)
스크린샷
리뷰어에게