Feat: 콜렉션 상세페이지 및 폴더 이름 변경, 삭제 기능 개발 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkSohyunee
requested review from
Eugene-A-01,
kanglocal,
Nahyun-Kang and
seoyoung-min
|
@ParkSohyunee is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
seoyoung-min
approved these changes
Oct 27, 2024
ParkSohyunee
commented
Oct 27, 2024
Comment on lines
+14
to
+42
| export default function ShapeSimpleList({ list, hasImage }: ShapeSimpleListProps) { | ||
| return ( | ||
| <Link | ||
| href={`/list/${list.id}`} | ||
| className={styles.contentVariant[hasImage ? 'round' : 'square']} | ||
| style={assignInlineVars({ | ||
| [styles.imageUrl]: `url(${hasImage ? list.representativeImageUrl : ''})`, | ||
| })} | ||
| > | ||
| <div className={styles.category}>{list.category}</div> | ||
| <div className={styles.info}> | ||
| <h3 className={styles.title[hasImage ? 'white' : 'black']}>{list.title}</h3> | ||
| <p className={styles.owner[hasImage ? 'white' : 'black']}>{list.ownerNickname}</p> | ||
| </div> | ||
| <ul className={styles.items}> | ||
| {list.listItems.map((item) => ( | ||
| <li key={item.id} className={styles.itemVariant[hasImage ? 'blue' : 'white']}> | ||
| <span> | ||
| {item.rank} | ||
| {`.`} | ||
| </span> | ||
| <span>{item.title}</span> | ||
| </li> | ||
| ))} | ||
| </ul> | ||
| <p className={styles.date[hasImage ? 'white' : 'black']}>{formatDate(list.updatedDate)}</p> | ||
| </Link> | ||
| ); | ||
| } |
There was a problem hiding this comment.
@kanglocal 현지님, 콜렉션 리스트 및 검색페이지에서도 사용하는 Simple리스트를 ShapeSimpleList 공통 컴포넌트로 만들어 두었습니다. 검색페이지 작업하실 때 참고 부탁드립니다~!!
ParkSohyunee
commented
Oct 27, 2024
There was a problem hiding this comment.
@seoyoung-min 서영님, ver3.0 BottomSheet 컴포넌트를 공통 컴포넌트로 만들어 두었습니다. Contents, Button 등 필요에따라 사용하시면 될 것 같습니다~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항 (optional)
스크린샷
콜렉션 상세페이지
바텀시트
애니메이션 확인 (수정 버튼 -> 폴더 이름 변경하기 -> 취소)
리뷰어에게