Feat: 홈(구 탐색) 개편 #263
Merged
Feat: 홈(구 탐색) 개편 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nahyun-Kang is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
auto-assign
bot
requested review from
Eugene-A-01,
kanglocal,
ParkSohyunee and
seoyoung-min
ParkSohyunee
approved these changes
Oct 28, 2024
Comment on lines
27
to
50
| const [isSearchBarOpened, setIsSearchBarOpened] = useState(false); | ||
| const { isOn, handleSetOn, handleSetOff } = useBooleanOutput(); | ||
| const [isLoggedIn, setIsLoggedIn] = useState(false); // 로그인 상태를 관리하는 useState 추가 | ||
|
|
||
| const { user } = useUser(); | ||
|
|
||
| const { data: userData } = useQuery<UserType>({ | ||
| queryKey: [QUERY_KEYS.userOne, user.id], | ||
| queryFn: () => getUserOne(user.id as number), | ||
| enabled: !!user.id, | ||
| }); | ||
|
|
||
| const handleAuthButtonClick = () => { | ||
| handleSetOn(); | ||
| }; | ||
|
|
||
| const handleInactivateSearchBar = () => { | ||
| setIsSearchBarOpened(false); | ||
| }; | ||
|
|
||
| const handleSearchIconClick = () => { | ||
| setIsSearchBarOpened(true); | ||
| }; | ||
|
|
There was a problem hiding this comment.
검색바 오픈 상태를 관리하는 부분도 hook useBooleanOutput을 사용해서 리팩토링하면 좋을 것 같아요.
const { isOn: isSearchBarOpened , handleSetOn: handleSearchBarOpened, handleSetOff: handleSetSearchBarClosed } = useBooleanOutput();
There was a problem hiding this comment.
항상 더 나은 대안을 주셔서 너무 감사합니다...
Comment on lines
13
to
28
| <button | ||
| onClick={() => setCurrentTab('recommendation')} | ||
| className={currentTab === 'recommendation' ? `${styles.activeTab}` : `${styles.tabButton}`} | ||
| > | ||
| 추천 | ||
| </button> | ||
| <button | ||
| onClick={() => setCurrentTab('recent')} | ||
| className={currentTab === 'recent' ? `${styles.activeTab}` : `${styles.tabButton}`} | ||
| > | ||
| 최신 | ||
| </button> | ||
| <button | ||
| onClick={() => setCurrentTab('following')} | ||
| className={currentTab === 'following' ? `${styles.activeTab}` : `${styles.tabButton}`} | ||
| > |
There was a problem hiding this comment.
선택된 탭에 따른 스타일 적용하는 부분은 따로 함수로 빼두면 좋을 것 같아요.
// 탭 스타일을 정하는 함수
const getButtonStyle = (selectedTap: string) => {
return currentTab === selectedTap ? styles.activeTab : styles.tabButton;
};
// 사용
<button onClick={() => setCurrentTab('recommendation')} className={getButtonStyle('recommendation')}>
</button>
There was a problem hiding this comment.
헙 대박....훨씬 깔끔하네요 ㅠㅠ 감사합니다..!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항 (optional)
[남은 작업]
@kanglocal 현지님 검색 바 받아서 제가 추가하겠습니다!
관련 이슈 (optional)
스크린샷
홈 > 추천
홈 > 최신
홈 > 팔로잉
리뷰어에게