HOTFIX: 리스트 수정 아이템 스탭 미리보기 이미지 오류 해결 및 헤더 컴포넌트 높이 수정 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seoyoung-min is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
auto-assign
bot
requested review from
Eugene-A-01,
kanglocal,
Nahyun-Kang and
ParkSohyunee
ParkSohyunee
approved these changes
Feb 15, 2024
Comment on lines
21
to
22
| imageFile: FileList | String; | ||
| }; |
There was a problem hiding this comment.
서영님, imageFile 타입중 string이 대문자로 되어있는데 소문자로 수정해야할 것 같습니다~~!
Comment on lines
+47
to
49
| } | ||
| }, [props]); | ||
|
|
There was a problem hiding this comment.
서영님, 혹시 이 부분은 의존성 배열에 props 전체보다는 props.imageFile 등 구체적으로 넣어주는 것이 나아보이는데 서영님 생각은 어떠신가용?!
There was a problem hiding this comment.
소현님, 안그래도 해당 부분에 props.type이랑 props.imageFile을 넣으려했는데, props.imageFile이 link preview에는 없어서 오류가 뜨더라구요ㅠㅠ
아예 둘을 분리하는 방향도 고민이 되네요!! 조금 더 생각해보겠습니다!!
Nahyun-Kang
approved these changes
Feb 15, 2024
Eugene-A-01
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
리뷰어에게