Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_unused_parameters #40

Open
zeydabadi opened this issue Aug 30, 2024 · 1 comment
Open

find_unused_parameters #40

zeydabadi opened this issue Aug 30, 2024 · 1 comment

Comments

@zeydabadi
Copy link

Hi,

I wonder if setting find_unused_parameters=False in the DDP constructor is safe to avoid unnecessary computation and improve performance.
Please advise.

Thank you

@935963004
Copy link
Owner

Since some parameter names are different in the public checkpoint from the code, so find_unused_parameters should be True if you are using the public checkpoint. In our case, unnecessary computation is minor and can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants