-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up to compliant Int work #3430
Merged
StevenACoffman
merged 8 commits into
99designs:master
from
phughes-scwx:issue-3214-follow-up
Dec 10, 2024
Merged
Follow up to compliant Int work #3430
StevenACoffman
merged 8 commits into
99designs:master
from
phughes-scwx:issue-3214-follow-up
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, coverage updated and the uuid binding is retained in the init template. 🚀 |
This is great! I super appreciate this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, this is a follow up to #3409.
The introduction of the UUID binding in to the
gqlgen init
template was part of aligning this content and the version in the config docs. Since there is already a divergence in the federation section, I think it'd make sense to also remove the UUID from init template, since:To that end, this PR removes that line that was added to the template.Ed: reverted.Additionally, this PR ensures that uint32 unmarshalers return errors if the values they marshal overflow. It also lumps int32, uint32, and uint negative signed numbers into a group of errors that can be "caught" and handled as a class, either via logs/metrics or helpful messages to clients. This can be useful since an API designed to accept only certain types of integers may drift in scope and start to receive other integers that are valid in theory, but cause confusing errors.
I have: