From d535e0ae4f73990f8d89ec5ddb4b788254f0a931 Mon Sep 17 00:00:00 2001 From: Miroslav Koula Date: Mon, 22 Aug 2016 16:01:15 +0200 Subject: [PATCH 1/2] Nette Frameworks in it's config file which generates DI Container is using annotations which are missing here. --- lib/Thumbor/Url/BuilderFactory.php | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/lib/Thumbor/Url/BuilderFactory.php b/lib/Thumbor/Url/BuilderFactory.php index 429d649..a543cd9 100644 --- a/lib/Thumbor/Url/BuilderFactory.php +++ b/lib/Thumbor/Url/BuilderFactory.php @@ -24,17 +24,31 @@ class BuilderFactory private $server; private $secret; + /** + * @param $server + * @param null $secret + * @return BuilderFactory + */ public static function construct($server, $secret=null) { return new self($server, $secret); } + /** + * BuilderFactory constructor. + * @param $server + * @param null $secret + */ public function __construct($server, $secret=null) { $this->server = $server; $this->secret = $secret; } + /** + * @param $original + * @return Builder + */ public function url($original) { return Builder::construct($this->server, $this->secret, $original); From d6b10ad6e5cf60b683096aa83d30ad6cdcf30517 Mon Sep 17 00:00:00 2001 From: Miroslav Koula Date: Tue, 23 Aug 2016 10:54:07 +0200 Subject: [PATCH 2/2] Annatation parameter fixes --- lib/Thumbor/Url/BuilderFactory.php | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/Thumbor/Url/BuilderFactory.php b/lib/Thumbor/Url/BuilderFactory.php index a543cd9..8ab162b 100644 --- a/lib/Thumbor/Url/BuilderFactory.php +++ b/lib/Thumbor/Url/BuilderFactory.php @@ -25,8 +25,8 @@ class BuilderFactory private $secret; /** - * @param $server - * @param null $secret + * @param string $server + * @param string|null $secret * @return BuilderFactory */ public static function construct($server, $secret=null) @@ -35,9 +35,8 @@ public static function construct($server, $secret=null) } /** - * BuilderFactory constructor. - * @param $server - * @param null $secret + * @param string $server + * @param string|null $secret */ public function __construct($server, $secret=null) { @@ -46,7 +45,7 @@ public function __construct($server, $secret=null) } /** - * @param $original + * @param string $original * @return Builder */ public function url($original)