Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement updated retransmission logic for splice_locked #2987

Open
t-bast opened this issue Jan 28, 2025 · 0 comments
Open

Implement updated retransmission logic for splice_locked #2987

t-bast opened this issue Jan 28, 2025 · 0 comments
Assignees

Comments

@t-bast
Copy link
Member

t-bast commented Jan 28, 2025

While working on taproot tests for splicing, @sstone discovered that what was previously a harmless race condition actually becomes an issue when using taproot channels. This is detailed in lightning/bolts#1223 and lead to changes in the reestablish logic to fix that race condition, which was added to the splicing spec in lightning/bolts@2c1b500

I think we should implement those changes immediately in eclair and lightning-kmp, with the following tweaks for backwards-compatibility:

  • we should handle reading the my_current_funding_locked
  • if it is included, we should apply the requirements laid out in lightning/bolts@2c1b500
  • if it isn't included, we should keep retransmitting our previous splice_locked like we currently do
  • but we shouldn't set my_current_funding_locked yet, because current nodes don't know how to read it and it has an even type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants