Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] timestamps to long #792

Closed
celevra opened this issue Jan 26, 2025 · 2 comments
Closed

[BUG] timestamps to long #792

celevra opened this issue Jan 26, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@celevra
Copy link

celevra commented Jan 26, 2025

hi,

if i create a entry with keyguard the timestamps are like this:

2024-03-21T17:59:09.513817200Z

but bitwarden needs the timestamps with 6 digits instead of 9.
if i sync one of the entries with the official bitwarden app (the new one), the apps panics with this error:

01-26 18:59:18.048 16187 10116 W NetworkResultCall: java.time.format.DateTimeParseException: Text '2024-07-01T08:24:30.464337348Z' could not be parsed at index 27
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at java.time.format.DateTimeFormatter.parseResolved0(DateTimeFormatter.java:2050)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at java.time.format.DateTimeFormatter.parse(DateTimeFormatter.java:1952)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at java.time.ZonedDateTime.parse(ZonedDateTime.java:593)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at com.x8bit.bitwarden.data.platform.datasource.network.serializer.ZonedDateTimeSerializer.deserialize(ZonedDateTimeSerializer.kt:27)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at com.x8bit.bitwarden.data.platform.datasource.network.serializer.ZonedDateTimeSerializer.deserialize(ZonedDateTimeSerializer.kt:15)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:69)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.ContextualSerializer.deserialize(ContextualSerializer.kt:67)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:69)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableValue(AbstractDecoder.kt:43)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.encoding.AbstractDecoder.decodeNullableSerializableElement(AbstractDecoder.kt:78)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at com.x8bit.bitwarden.data.vault.datasource.network.model.SyncResponseJson$Cipher$Login$$serializer.deserialize(SyncResponseJson.kt:688)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at com.x8bit.bitwarden.data.vault.datasource.network.model.SyncResponseJson$Cipher$Login$$serializer.deserialize(SyncResponseJson.kt:688)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:69)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableValue(AbstractDecoder.kt:43)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.encoding.AbstractDecoder.decodeNullableSerializableElement(AbstractDecoder.kt:78)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at com.x8bit.bitwarden.data.vault.datasource.network.model.SyncResponseJson$Cipher$$serializer.deserialize(SyncResponseJson.kt:435)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at com.x8bit.bitwarden.data.vault.datasource.network.model.SyncResponseJson$Cipher$$serializer.deserialize(SyncResponseJson.kt:435)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:69)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableValue(AbstractDecoder.kt:43)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableElement(AbstractDecoder.kt:70)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableElement(StreamingJsonDecoder.kt:168)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.encoding.CompositeDecoder.decodeSerializableElement$default(Decoding.kt:539)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.internal.CollectionLikeSerializer.readElement(CollectionSerializers.kt:80)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.internal.AbstractCollectionSerializer.readElement$default(CollectionSerializers.kt:51)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.internal.AbstractCollectionSerializer.merge(CollectionSerializers.kt:36)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.internal.AbstractCollectionSerializer.deserialize(CollectionSerializers.kt:43)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:69)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.encoding.AbstractDecoder.decodeSerializableValue(AbstractDecoder.kt:43)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.encoding.AbstractDecoder.decodeNullableSerializableElement(AbstractDecoder.kt:78)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at com.x8bit.bitwarden.data.vault.datasource.network.model.SyncResponseJson$$serializer.deserialize(SyncResponseJson.kt:26)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at com.x8bit.bitwarden.data.vault.datasource.network.model.SyncResponseJson$$serializer.deserialize(SyncResponseJson.kt:26)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:69)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at kotlinx.serialization.json.Json.decodeFromString(Json.kt:149)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at retrofit2.converter.kotlinx.serialization.Serializer$FromString.fromResponseBody(Serializer.kt:26)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at retrofit2.converter.kotlinx.serialization.DeserializationStrategyConverter.convert(DeserializationStrategyConverter.kt:11)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at retrofit2.converter.kotlinx.serialization.DeserializationStrategyConverter.convert(DeserializationStrategyConverter.kt:7)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at retrofit2.OkHttpCall.parseResponse(OkHttpCall.java:246)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at retrofit2.OkHttpCall$1.onResponse(OkHttpCall.java:156)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
01-26 18:59:18.048 16187 10116 W NetworkResultCall:     at java.lang.Thread.run(Thread.java:1012)

i have hundreds of entries with this dates ;-) also created an bug report @vaultwarden (dani-garcia/vaultwarden#4386)

can you fix it in the next release and correct the timestamps?

regards

@AChep
Copy link
Owner

AChep commented Jan 26, 2025

@celevra you can test on this APK file from this build: https://github.com/AChep/keyguard-app/actions/runs/12978348498 it should auto-fix all the entries, hopefully 😄

@AChep AChep closed this as completed Jan 26, 2025
@celevra
Copy link
Author

celevra commented Jan 27, 2025

that worked! Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants