Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/create nft token #83

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Feature/create nft token #83

merged 2 commits into from
Aug 6, 2024

Conversation

AbigailDeng
Copy link
Collaborator

No description provided.

@vizipi Vizipi
Copy link

vizipi bot commented Aug 6, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
50.00% yongenaelf 2 1
50.00% eanzhao 1 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
yarn.lock88.89%24 out of 27 times
src/utils/constants.js62.96%17 out of 27 times
src/command/baseSubCommand.js59.26%16 out of 27 times
src/command/config.js59.26%16 out of 27 times
src/command/proposal.js59.26%16 out of 27 times
src/command/getBlkInfo.js55.56%15 out of 27 times
src/command/call.js55.56%15 out of 27 times
src/command/dappServer/socket.js48.15%13 out of 27 times
src/command/getTxResult.js44.44%12 out of 27 times
src/index.js40.74%11 out of 27 times

Committed file ranks

(click to expand)
  • 95.31%[src/utils/utils.js]
  • 99.22%[package.json]

    • @github-actions GitHub Actions
    Copy link

    github-actions bot commented Aug 6, 2024

    🔴 Total coverage is lower than the default branch

    Lines Branches Functions Statements
    95.95% (-0.29%) 89.38% (-0.22%) 97.53% (-0.60%) 95.79% (-0.38%)

    Detailed report

    1 file with a coverage regression
    File Lines Branches Functions Statements
    🔴 /home/runner/work/aelf-command/aelf-command/src/utils/utils.js 85.38% (-1.12%) 79.16% (-0.62%) 90.62% (-2.92%) 84.97% (-1.61%)

    @hzz780 hzz780 merged commit 275afc1 into master Aug 6, 2024
    1 of 2 checks passed
    @AbigailDeng AbigailDeng linked an issue Aug 7, 2024 that may be closed by this pull request
    aelf-command - bug fix #84
    Open
    2 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    aelf-command - bug fix
    2 participants
    @AbigailDeng @hzz780