Skip to content
This repository has been archived by the owner on Mar 30, 2023. It is now read-only.

Replace gettext with 'polib' and add test for 'fix_style' function #77

Closed
wants to merge 3 commits into from
Closed

Conversation

mondeja
Copy link
Contributor

@mondeja mondeja commented Sep 15, 2020

  • gettext dependency replaced with Python polib.
  • Added test for fix_style function.
  • Added type hints for boolean optional arguments.
  • Some reformatting to match flake8 and black style.

Closes #76

Copy link
Collaborator

@Seluj78 Seluj78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the merge request ! I have not tested your changes yet, and I will wait for @JulienPalard's review before merging

powrap/powrap.py Outdated Show resolved Hide resolved
@JulienPalard
Copy link
Collaborator

Hi thanks for contributing, and thanks for your time!

I'd love to see a Python implementation of the msgcat/poedit wrapping sadly there's not.

If we apply this PR, projects using powrap will be entierly rewrapped (meaning a colossal diff), while powrap is here to lower the diff in project histories by unifying wrapping convention.

I tried on https://github.com/python/python-docs-fr, a powrap *.po */*.po:

$ git diff | wc -l
243576

So no, polib is not an acceptable replacement.

(Yes we really need to stick to msgcat / poedit wrapping as there's a lot of contributors using poedit, so they don't have to care about powrap at all. On the other hand there's nobody editing files with a polib-compatible wrapping convention).

If you're still interested in dropping msgcat dependencies, I started https://github.com/JulienPalard/powrap/tree/from_msgcat that could be a way of doing it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove msgcat dependency
3 participants