Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oras tag should not create referrers tags #1436

Closed
qweeah opened this issue Jun 28, 2024 · 4 comments · Fixed by #1435 or #1577 · May be fixed by benhoff/build#3, chainsx/build#2 or HeyMeco/build#1
Closed

oras tag should not create referrers tags #1436

qweeah opened this issue Jun 28, 2024 · 4 comments · Fixed by #1435 or #1577 · May be fixed by benhoff/build#3, chainsx/build#2 or HeyMeco/build#1
Labels
bug Something isn't working

Comments

@qweeah
Copy link
Contributor

qweeah commented Jun 28, 2024

Although tagging a referrer artifact manifest is discouraged, it is still doable. However, re-tagging is implemented as pushing the exact manifest again to the remote server. According to the distribution-spec, if the remote server does not support referrers API, it will go for the referrers tag schema case. However, it is not necessary since the manifest is already there, we are just adding a new tag not really pushing a new manifest.

In summary, tagging a referrers manifest should never go for the tag schema even if the server does not support referrers API since the referrer manifest is already there on the server.

Originally posted by @shizhMSFT in #1435 (comment)

@shizhMSFT shizhMSFT added the bug Something isn't working label Jun 28, 2024
@qweeah
Copy link
Contributor Author

qweeah commented Jul 1, 2024

BTW this bug generates unwanted referrer tags (256-xxx) ONLY in registries that haven't implemented OCI Distribution Spec v1.1.0.

@FeynmanZhou FeynmanZhou linked a pull request Jul 2, 2024 that will close this issue
4 tasks
@qweeah
Copy link
Contributor Author

qweeah commented Jul 10, 2024

@njucjc Can you help confirm if this has met your expectation described in #1435? You may build from main branch or use ghcr.io/oras-project/oras:main. Thanks in adavnce.

@njucjc
Copy link
Contributor

njucjc commented Jul 11, 2024

@njucjc Can you help confirm if this has met your expectation described in #1435? You may build from main branch or use ghcr.io/oras-project/oras:main. Thanks in adavnce.

@qweeah I already try it out, It works

@qweeah
Copy link
Contributor Author

qweeah commented Jul 11, 2024

Closing as it's resolved.

@qweeah qweeah closed this as completed Jul 11, 2024
This was referenced Dec 16, 2024
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment