From b4a01aa8e96e061952fdd85e5fa58bfa5bf85659 Mon Sep 17 00:00:00 2001
From: Md Azizul Hakim <mdazizulhakim.cse@gmail.com>
Date: Mon, 4 Nov 2024 12:51:05 +0600
Subject: [PATCH] update readme

---
 README.md         | 77 +++++++++++++++++++++++++++++++++++------------
 package-lock.json |  4 +--
 package.json      |  2 +-
 3 files changed, 61 insertions(+), 22 deletions(-)

diff --git a/README.md b/README.md
index 44d2087..89c4a1e 100644
--- a/README.md
+++ b/README.md
@@ -189,7 +189,13 @@ import crypto from 'crypto';
 
 function generateXsecurityToken(secretKey: string, expirySeconds = 300): string {
   const expiryTimestamp = Math.floor(Date.now() / 1000) + expirySeconds;
-  const payload = { expiry: expiryTimestamp };
+  const randomBytes = crypto.randomBytes(16).toString('hex'); // Add randomness
+  const payload = {
+    expiry: expiryTimestamp,
+    nonce: randomBytes,
+    iat: Date.now()
+  };
+
   const token = Buffer.from(JSON.stringify(payload)).toString('base64');
   const signature = crypto
     .createHmac('sha256', secretKey)
@@ -206,25 +212,43 @@ const token = generateXsecurityToken('your-secret-key');
 ### Python
 
 ```python
-import hmac
+import time
 import json
+import hmac
 import base64
+import secrets
 import hashlib
-import time
+from typing import Optional
 
 def generate_xsecurity_token(secret_key: str, expiry_seconds: int = 300) -> str:
-    expiry = int(time.time()) + expiry_seconds
-    payload = {'expiry': expiry}
-
-    # Create token
+    """
+    Generate a secure token with expiry and nonce.
+
+    Args:
+        secret_key (str): Secret key for signing
+        expiry_seconds (int): Token validity duration in seconds
+
+    Returns:
+        str: Generated security token
+    """
+    expiry_timestamp = int(time.time()) + expiry_seconds
+    random_bytes = secrets.token_hex(16)  # 16 bytes = 32 hex chars
+
+    payload = {
+        "expiry": expiry_timestamp,
+        "nonce": random_bytes,
+        "iat": int(time.time() * 1000)  # milliseconds
+    }
+
+    # Convert payload to base64
     token = base64.b64encode(
-        json.dumps(payload).encode()
-    ).decode()
+        json.dumps(payload).encode('utf-8')
+    ).decode('utf-8')
 
     # Generate signature
     signature = hmac.new(
-        secret_key.encode(),
-        token.encode(),
+        secret_key.encode('utf-8'),
+        token.encode('utf-8'),
         hashlib.sha256
     ).hexdigest()
 
@@ -235,18 +259,33 @@ def generate_xsecurity_token(secret_key: str, expiry_seconds: int = 300) -> str:
 
 ```dart
 import 'dart:convert';
+import 'dart:math';
 import 'package:crypto/crypto.dart';
 
-String generateXsecurityToken(String secretKey, {int expirySeconds = 300}) {
-  final expiry = DateTime.now().millisecondsSinceEpoch ~/ 1000 + expirySeconds;
-  final payload = {'expiry': expiry};
+class XSecurityToken {
+  static String generate(String secretKey, {int expirySeconds = 300}) {
+    final expiryTimestamp = (DateTime.now().millisecondsSinceEpoch ~/ 1000) + expirySeconds;
+
+    // Generate random bytes for nonce
+    final random = Random.secure();
+    final randomBytes = List<int>.generate(16, (i) => random.nextInt(256));
+    final nonce = randomBytes.map((byte) => byte.toRadixString(16).padLeft(2, '0')).join();
+
+    final payload = {
+      'expiry': expiryTimestamp,
+      'nonce': nonce,
+      'iat': DateTime.now().millisecondsSinceEpoch
+    };
 
-  final token = base64Url.encode(utf8.encode(jsonEncode(payload)));
-  final signature = Hmac(sha256, utf8.encode(secretKey))
-      .convert(utf8.encode(token))
-      .toString();
+    // Convert payload to base64
+    final token = base64Encode(utf8.encode(jsonEncode(payload)));
 
-  return '$token.$signature';
+    // Generate signature
+    final hmacSha256 = Hmac(sha256, utf8.encode(secretKey));
+    final signature = hmacSha256.convert(utf8.encode(token)).toString();
+
+    return '$token.$signature';
+  }
 }
 ```
 
diff --git a/package-lock.json b/package-lock.json
index bac940f..a0a6558 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "nestjs-xsecurity",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "nestjs-xsecurity",
-      "version": "1.0.1",
+      "version": "1.0.2",
       "license": "MIT",
       "bin": {
         "nestjs-xsecurity": "dist/cli/bin/install.js"
diff --git a/package.json b/package.json
index 5775546..7f1ca3c 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nestjs-xsecurity",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Security middleware for NestJS applications with token validation and rate limiting",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",