Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for new models #115

Open
karthik4579 opened this issue Sep 30, 2024 · 6 comments
Open

Request for new models #115

karthik4579 opened this issue Sep 30, 2024 · 6 comments

Comments

@karthik4579
Copy link

Will support for new models be added like Auraflow and Flux be added ?

https://huggingface.co/fal/AuraFlow
https://huggingface.co/black-forest-labs/FLUX.1-dev

@entrpn
Copy link
Collaborator

entrpn commented Oct 3, 2024

@karthik4579 there are plans to add Flux in the future

@gabeweisz
Copy link

Can you comment on the expected timeline for adding flux? Would you be open to a PR that adds it (we haven't built it yet, but could work on it if you are open to such a PR)

@entrpn
Copy link
Collaborator

entrpn commented Nov 4, 2024

@gabeweisz PRs are always welcomed :)

I am planning to start working on flux in beginning of 2025. There is already a JAX Flux repo that runs on both GPUs and TPUs, but it needs to be optimized. repo

@jcaraban
Copy link

jcaraban commented Jan 24, 2025

@entrpn together with @gabeweisz we have a working implementation of Flux.1 in a private fork of MaxDiffusion. We plan to submit a PR soon, but I'm reaching now as I see @jfacevedo-google has resumed work in his flux_impl branch this week. We originally started from jflux using Flax.nnx, but once that worked we migrated to linen.nn on top of Juan's flux stale branch. At this point our implementation is probably not too different from what's brewing in flux_impl. Our FSDP sharding is not optimal but works. Performance is on par with HF.diffusers.FluxTransformer2DModel or slightly better for MI300x. What do you think?

@entrpn
Copy link
Collaborator

entrpn commented Jan 24, 2025

@jcaraban and @gabeweisz thanks for working on this. It sounds like you took the same approach I'm taking. Please open a PR and we can work together on merging it to main. Excited to test it out!

@gabeweisz
Copy link

We plan on submitting an initial PR on Monday. We do expect you to have feedback on how we have structured the code and done some of the implementation, and are looking forward to working with you on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants