Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up the public release via pypi #6

Open
3 of 4 tasks
haz opened this issue Jan 12, 2025 · 3 comments
Open
3 of 4 tasks

Fix up the public release via pypi #6

haz opened this issue Jan 12, 2025 · 3 comments
Assignees
Labels
type: cleanup type: documentation Documentation type: enhancement Extensions or improvements type: feature request New feature or request

Comments

@haz
Copy link
Contributor

haz commented Jan 12, 2025

These are the things I've noticed wrong:

@haz haz assigned haz and ssardina Jan 12, 2025
@haz haz added bug labels Jan 12, 2025
@haz haz mentioned this issue Jan 13, 2025
ssardina added a commit that referenced this issue Jan 14, 2025
@ssardina
Copy link
Collaborator

Now that fond-utils CLI works well, I am refactoring the package data a bit, mostly as done in the pddl package..

https://github.com/AI-Planning/pddl/blob/main/setup.py

@ssardina
Copy link
Collaborator

ssardina commented Jan 14, 2025

Have continued your work a bit @haz , refactor the way we do the binary (I think it is better this way by happy to be convinced otherwise #8) and factor out a bit the package info (author (alphabetical now, thanks 😉 but makes no sense otherwise I think; version, etc).

Done for today, Happy that you undo all the changes if you have a reason 👍 Thanks for pushing this! Do a pull of the package-fixes branch...

(still not tested with the pypi repo)

@haz
Copy link
Contributor Author

haz commented Jan 14, 2025

Works like a charm from a fresh pypi install fond-utils -- thanks for the efforts!

@ssardina ssardina removed bug labels Jan 14, 2025
@ssardina ssardina changed the title Fix up the public release Fix up the public release via pypi Jan 14, 2025
@ssardina ssardina added type: feature request New feature or request type: documentation Documentation type: enhancement Extensions or improvements type: cleanup labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup type: documentation Documentation type: enhancement Extensions or improvements type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants