Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Thoth schema updated command #185

Merged
merged 3 commits into from
Jun 3, 2022
Merged

Create Thoth schema updated command #185

merged 3 commits into from
Jun 3, 2022

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Nov 11, 2021 •
edited by harshad16
Loading

Related Issues and Dependencies

Related: thoth-station/thoth-application#2584
#184

This introduces a breaking change

  • No

@sesheta sesheta requested review from goern and harshad16 November 11, 2021 16:32
@fridex
Copy link
Contributor Author

fridex commented Nov 11, 2021

/deploy

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 11, 2021
harshad16
harshad16 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@harshad16
Copy link
Member

/test all

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
@sesheta
Copy link
Contributor

sesheta commented Feb 15, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2022
codificat
codificat requested changes Feb 20, 2022
View reviewed changes
Copy link
Member

@codificat codificat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict to fix and a missing docstring that pre-commit is complaining about

aicoe/sesheta/actions/chat.py
@@ -76,6 +97,22 @@ async def make_release_issue(request: dict):
return f"Creating the issue failed. \n Log - {resp_text}"


async def make_kebechet_update_issue(repo_name: str) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit is complaining of a missing docstring here

@sesheta
Copy link
Contributor

sesheta commented Mar 22, 2022

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 22, 2022
@sesheta
Copy link
Contributor

sesheta commented Apr 22, 2022

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

@sesheta sesheta closed this Apr 22, 2022
@sesheta
Copy link
Contributor

sesheta commented Apr 22, 2022

@sesheta: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harshad16 harshad16 reopened this Jun 3, 2022
@harshad16
Copy link
Member

/remove-lifecycle rotten
/lgtm
/approve

Thank you 💯

@sesheta sesheta removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 3, 2022
@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2022
@harshad16 harshad16 merged commit 433951f into AICoE:master Jun 3, 2022
@sesheta
Copy link
Contributor

sesheta commented Jun 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta
Copy link
Contributor

sesheta commented Jun 3, 2022

@fridex: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit 2eb3e59 link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

codificat pushed a commit to codificat/sefkhet-abwy that referenced this pull request Jun 8, 2022
@fridex @codificat
Create Thoth schema updated command
2fbdc37 
Incorporating changes from AICoE#185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codificat codificat codificat requested changes

@harshad16 harshad16 harshad16 approved these changes

@goern goern Awaiting requested review from goern

Assignees

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fridex @harshad16 @sesheta @codificat