From a9bc5a7fd390b735e2aba62466d36c7c82928b47 Mon Sep 17 00:00:00 2001
From: tmadlener <thomas.madlener@desy.de>
Date: Wed, 12 Jun 2024 21:09:11 +0200
Subject: [PATCH] Fix potential race condition for writing GenericParameters

---
 include/podio/GenericParameters.h     | 14 ++++++++++----
 include/podio/utilities/RootHelpers.h |  3 ++-
 src/RNTupleWriter.cc                  |  3 +--
 src/ROOTWriter.cc                     |  8 ++++----
 4 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/include/podio/GenericParameters.h b/include/podio/GenericParameters.h
index f0f2b164a..4f41aad63 100644
--- a/include/podio/GenericParameters.h
+++ b/include/podio/GenericParameters.h
@@ -118,7 +118,7 @@ class GenericParameters {
 
   /// Get all the available values for a given type
   template <typename T, typename = EnableIfValidGenericDataType<T>>
-  std::vector<std::vector<T>> getValues() const;
+  std::tuple<std::vector<std::string>, std::vector<std::vector<T>>> getKeysAndValues() const;
 
   /// erase all elements
   void clear() {
@@ -263,8 +263,9 @@ std::vector<std::string> GenericParameters::getKeys() const {
 }
 
 template <typename T, typename>
-std::vector<std::vector<T>> GenericParameters::getValues() const {
+std::tuple<std::vector<std::string>, std::vector<std::vector<T>>> GenericParameters::getKeysAndValues() const {
   std::vector<std::vector<T>> values;
+  std::vector<std::string> keys;
   auto& mtx = getMutex<T>();
   const auto& map = getMap<T>();
   {
@@ -272,9 +273,14 @@ std::vector<std::vector<T>> GenericParameters::getValues() const {
     // values
     std::lock_guard lock{mtx};
     values.reserve(map.size());
-    std::transform(map.begin(), map.end(), std::back_inserter(values), [](const auto& pair) { return pair.second; });
+    keys.reserve(map.size());
+
+    for (const auto& [k, v] : map) {
+      keys.emplace_back(k);
+      values.emplace_back(v);
+    }
   }
-  return values;
+  return {keys, values};
 }
 
 template <typename T, template <typename...> typename VecLike>
diff --git a/include/podio/utilities/RootHelpers.h b/include/podio/utilities/RootHelpers.h
index 884382b6e..360ef6674 100644
--- a/include/podio/utilities/RootHelpers.h
+++ b/include/podio/utilities/RootHelpers.h
@@ -57,7 +57,8 @@ namespace root_utils {
     ParamStorage(ParamStorage&&) = default;
     ParamStorage& operator=(ParamStorage&&) = default;
 
-    ParamStorage(const std::vector<std::string>& ks, const std::vector<std::vector<T>>& vs) : keys(ks), values(vs) {
+    ParamStorage(std::tuple<std::vector<std::string>, std::vector<std::vector<T>>> keysValues) :
+        keys(std::move(std::get<0>(keysValues))), values(std::move(std::get<1>(keysValues))) {
     }
 
     /// Get a pointer to the stored keys for binding it to a TBranch
diff --git a/src/RNTupleWriter.cc b/src/RNTupleWriter.cc
index 55d23167f..bbff2a392 100644
--- a/src/RNTupleWriter.cc
+++ b/src/RNTupleWriter.cc
@@ -47,8 +47,7 @@ void RNTupleWriter::fillParams(const GenericParameters& params, CategoryInfo& ca
   auto& paramStorage = getParamStorage<T>(catInfo);
   auto& keys = paramStorage.keys;
   auto& values = paramStorage.values;
-  keys = params.getKeys<T>();
-  values = params.getValues<T>();
+  std::tie(keys, values) = params.getKeysAndValues<T>();
 #if ROOT_VERSION_CODE >= ROOT_VERSION(6, 31, 0)
   entry->BindRawPtr(root_utils::getGPKeyName<T>(), &keys);
   entry->BindRawPtr(root_utils::getGPValueName<T>(), &values);
diff --git a/src/ROOTWriter.cc b/src/ROOTWriter.cc
index df8e810fd..f0aab0acf 100644
--- a/src/ROOTWriter.cc
+++ b/src/ROOTWriter.cc
@@ -196,10 +196,10 @@ ROOTWriter::checkConsistency(const std::vector<std::string>& collsToWrite, const
 }
 
 void ROOTWriter::fillParams(CategoryInfo& catInfo, const GenericParameters& params) {
-  catInfo.intParams = {params.getKeys<int>(), params.getValues<int>()};
-  catInfo.floatParams = {params.getKeys<float>(), params.getValues<float>()};
-  catInfo.doubleParams = {params.getKeys<double>(), params.getValues<double>()};
-  catInfo.stringParams = {params.getKeys<std::string>(), params.getValues<std::string>()};
+  catInfo.intParams = params.getKeysAndValues<int>();
+  catInfo.floatParams = params.getKeysAndValues<float>();
+  catInfo.doubleParams = params.getKeysAndValues<double>();
+  catInfo.stringParams = params.getKeysAndValues<std::string>();
 }
 
 } // namespace podio