Introduce a createBuffers macro for the jinja template #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Sep 13, 2023
| {%- endmacro %} | ||
| {% endmacro %} | ||
|
|
||
| {% macro createBuffers(class, package_name, collection_type, OneToManyRelations, OneToOneRelations, VectorMembers, schemaVersion) %} |
There was a problem hiding this comment.
Suggested change
| {% macro createBuffers(class, package_name, collection_type, OneToManyRelations, OneToOneRelations, VectorMembers, schemaVersion) %} | |
| {% macro create_buffers(class, package_name, collection_type, OneToManyRelations, OneToOneRelations, VectorMembers, schemaVersion) %} |
consistency with other macros (and the release notes).
There was a problem hiding this comment.
Additionally, schemaVersion is currently unused (it will get it's usage in #472 though).
|
|
||
| return readBuffers; | ||
| } | ||
| {{ macros.createBuffers(class, package_name, collection_type, OneToManyRelations, OneToOneRelations, VectorMembers, 1) }} |
There was a problem hiding this comment.
Suggested change
| {{ macros.createBuffers(class, package_name, collection_type, OneToManyRelations, OneToOneRelations, VectorMembers, 1) }} | |
| {{ macros.create_buffers(class, package_name, collection_type, OneToManyRelations, OneToOneRelations, VectorMembers, 1) }} |
|
@tmadlener - I think we apply those changes directly after merging the schema evolution one. Would that be fine with you? |
tmadlener
changed the title
Ananya2003Gupta
pushed a commit
to Ananya2003Gupta/podio
that referenced
this pull request
Sep 26, 2023
* move Collection::createBuffers template into macro --------- Co-authored-by: tmadlener <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES
This extracts the create_buffers change from #472 as discussed in there.