diff --git a/include/podio/CollectionBufferFactory.h b/include/podio/CollectionBufferFactory.h index 531e54150..5c682564b 100644 --- a/include/podio/CollectionBufferFactory.h +++ b/include/podio/CollectionBufferFactory.h @@ -39,7 +39,6 @@ class CollectionBufferFactory { CollectionBufferFactory& operator=(CollectionBufferFactory const&) = delete; CollectionBufferFactory(CollectionBufferFactory&&) = delete; CollectionBufferFactory& operator=(CollectionBufferFactory&&) = delete; - ~CollectionBufferFactory() = default; /// Mutable instance only used for the initial registration of functions /// during library loading diff --git a/include/podio/CollectionIDTable.h b/include/podio/CollectionIDTable.h index 3cb2986d5..1ad53c8a5 100644 --- a/include/podio/CollectionIDTable.h +++ b/include/podio/CollectionIDTable.h @@ -14,7 +14,6 @@ class CollectionIDTable { public: CollectionIDTable(); - ~CollectionIDTable() = default; CollectionIDTable(const CollectionIDTable&) = delete; CollectionIDTable& operator=(const CollectionIDTable&) = delete; diff --git a/include/podio/DatamodelRegistry.h b/include/podio/DatamodelRegistry.h index 760adff19..e04b956d4 100644 --- a/include/podio/DatamodelRegistry.h +++ b/include/podio/DatamodelRegistry.h @@ -55,7 +55,6 @@ class DatamodelRegistry { // Mutable instance only used for the initial registration! static DatamodelRegistry& mutInstance(); - ~DatamodelRegistry() = default; DatamodelRegistry(const DatamodelRegistry&) = delete; DatamodelRegistry& operator=(const DatamodelRegistry&) = delete; DatamodelRegistry(DatamodelRegistry&&) = delete; diff --git a/include/podio/Frame.h b/include/podio/Frame.h index 2b5281142..0bc0ee17f 100644 --- a/include/podio/Frame.h +++ b/include/podio/Frame.h @@ -92,7 +92,6 @@ class Frame { struct FrameModel final : FrameConcept, public ICollectionProvider { FrameModel(std::unique_ptr data); - ~FrameModel() = default; FrameModel(const FrameModel&) = delete; FrameModel& operator=(const FrameModel&) = delete; FrameModel(FrameModel&&) = default; @@ -179,13 +178,6 @@ class Frame { /// Frame move assignment operator Frame& operator=(Frame&&) = default; - /// Frame destructor - /// - /// @note Since the Frame owns all the collections that have been put into it, - /// or that can be obtained from it, this invalidates all references to these - /// collections. - ~Frame() = default; - /// Get a collection from the Frame by name. /// /// @tparam CollT The type of the desired collection diff --git a/include/podio/GenericParameters.h b/include/podio/GenericParameters.h index fb67d9123..049681163 100644 --- a/include/podio/GenericParameters.h +++ b/include/podio/GenericParameters.h @@ -66,8 +66,6 @@ class GenericParameters { GenericParameters(GenericParameters&&) = default; GenericParameters& operator=(GenericParameters&&) = default; - ~GenericParameters() = default; - template std::optional get(const std::string& key) const; diff --git a/include/podio/LinkNavigator.h b/include/podio/LinkNavigator.h index 360afc90e..ed09532c9 100644 --- a/include/podio/LinkNavigator.h +++ b/include/podio/LinkNavigator.h @@ -67,7 +67,6 @@ class LinkNavigator { LinkNavigator& operator=(const LinkNavigator&) = default; LinkNavigator(LinkNavigator&&) = default; LinkNavigator& operator=(LinkNavigator&&) = default; - ~LinkNavigator() = default; /// Get all the *From* objects and weights that have links with the passed /// object diff --git a/include/podio/RNTupleReader.h b/include/podio/RNTupleReader.h index 36248c5ca..6d132bc90 100644 --- a/include/podio/RNTupleReader.h +++ b/include/podio/RNTupleReader.h @@ -33,8 +33,6 @@ class RNTupleReader { public: /// Create a RNTupleReader RNTupleReader() = default; - /// Destructor - ~RNTupleReader() = default; /// The RNTupleReader is not copy-able RNTupleReader(const RNTupleReader&) = delete; /// The RNTupleReader is not copy-able diff --git a/include/podio/ROOTLegacyReader.h b/include/podio/ROOTLegacyReader.h index 9383ca51b..98764134e 100644 --- a/include/podio/ROOTLegacyReader.h +++ b/include/podio/ROOTLegacyReader.h @@ -46,9 +46,6 @@ class ROOTLegacyReader { public: /// Create a SIOLegacyReader ROOTLegacyReader() = default; - /// Destructor - ~ROOTLegacyReader() = default; - /// The SIOLegacyReader is not copy-able ROOTLegacyReader(const ROOTLegacyReader&) = delete; /// The SIOLegacyReader is not copy-able diff --git a/include/podio/ROOTReader.h b/include/podio/ROOTReader.h index 7167411ec..bcad574ce 100644 --- a/include/podio/ROOTReader.h +++ b/include/podio/ROOTReader.h @@ -45,9 +45,6 @@ class ROOTReader { public: /// Create a ROOTReader ROOTReader() = default; - /// Destructor - ~ROOTReader() = default; - /// The ROOTReader is not copy-able ROOTReader(const ROOTReader&) = delete; /// The ROOTReader is not copy-able diff --git a/include/podio/Reader.h b/include/podio/Reader.h index d8209197e..3999fd863 100644 --- a/include/podio/Reader.h +++ b/include/podio/Reader.h @@ -42,8 +42,6 @@ class Reader { ReaderModel(ReaderModel&&) = default; ReaderModel& operator=(ReaderModel&&) = default; - ~ReaderModel() = default; - podio::Frame readNextFrame(const std::string& name) override { auto maybeFrame = m_reader->readNextEntry(name); if (maybeFrame) { @@ -100,7 +98,6 @@ class Reader { Reader& operator=(const Reader&) = delete; Reader(Reader&&) = default; Reader& operator=(Reader&&) = default; - ~Reader() = default; /// Read the next frame of a given category /// diff --git a/include/podio/SIOLegacyReader.h b/include/podio/SIOLegacyReader.h index d490fcd5e..001b6b45c 100644 --- a/include/podio/SIOLegacyReader.h +++ b/include/podio/SIOLegacyReader.h @@ -28,9 +28,6 @@ class SIOLegacyReader { public: /// Create a SIOLegacyReader SIOLegacyReader(); - /// Destructor - ~SIOLegacyReader() = default; - /// The SIOLegacyReader is not copy-able SIOLegacyReader(const SIOLegacyReader&) = delete; /// The SIOLegacyReader is not copy-able diff --git a/include/podio/SIOReader.h b/include/podio/SIOReader.h index f9f5ba02a..d8ce09367 100644 --- a/include/podio/SIOReader.h +++ b/include/podio/SIOReader.h @@ -27,9 +27,6 @@ class SIOReader { public: /// Create an SIOReader SIOReader(); - /// SIOReader destructor - ~SIOReader() = default; - /// The SIOReader is not copy-able SIOReader(const SIOReader&) = delete; /// The SIOReader is not copy-able diff --git a/include/podio/SchemaEvolution.h b/include/podio/SchemaEvolution.h index cb8803d26..5822a4c86 100644 --- a/include/podio/SchemaEvolution.h +++ b/include/podio/SchemaEvolution.h @@ -61,7 +61,6 @@ class SchemaEvolution { SchemaEvolution& operator=(const SchemaEvolution&) = delete; SchemaEvolution(SchemaEvolution&&) = delete; SchemaEvolution& operator=(SchemaEvolution&&) = delete; - ~SchemaEvolution() = default; /// Mutable instance only used for the initial registration of functions /// during library loading diff --git a/include/podio/UserDataCollection.h b/include/podio/UserDataCollection.h index 226d412fe..884f9e017 100644 --- a/include/podio/UserDataCollection.h +++ b/include/podio/UserDataCollection.h @@ -85,7 +85,6 @@ class UserDataCollection : public CollectionBase { UserDataCollection& operator=(const UserDataCollection&) = delete; UserDataCollection(UserDataCollection&&) = default; UserDataCollection& operator=(UserDataCollection&&) = default; - ~UserDataCollection() = default; /// The schema version of UserDataCollections static constexpr SchemaVersionT schemaVersion = 1; diff --git a/include/podio/Writer.h b/include/podio/Writer.h index 65f432787..d78c00e33 100644 --- a/include/podio/Writer.h +++ b/include/podio/Writer.h @@ -38,8 +38,6 @@ class Writer { WriterModel(WriterModel&&) = default; WriterModel& operator=(WriterModel&&) = default; - ~WriterModel() = default; - void writeFrame(const podio::Frame& frame, const std::string& category, const std::vector& collections) override { return m_writer->writeFrame(frame, category, collections); @@ -66,12 +64,6 @@ class Writer { Writer(Writer&&) = default; Writer& operator=(Writer&&) = default; - /// Destructor - /// - /// This also takes care of writing all the necessary metadata to read files - /// back again. - ~Writer() = default; - /// Store the given frame with the given category /// /// This stores all available categories from the passed frame diff --git a/include/podio/detail/Link.h b/include/podio/detail/Link.h index 0cb50135e..15d55b82f 100644 --- a/include/podio/detail/Link.h +++ b/include/podio/detail/Link.h @@ -107,9 +107,6 @@ class LinkT { return {nullptr}; } - /// Destructor - ~LinkT() = default; - /// Get the weight of the link float getWeight() const { return m_obj->data.weight; diff --git a/include/podio/detail/LinkCollectionData.h b/include/podio/detail/LinkCollectionData.h index 7c8c2d925..6b836fae9 100644 --- a/include/podio/detail/LinkCollectionData.h +++ b/include/podio/detail/LinkCollectionData.h @@ -42,7 +42,6 @@ class LinkCollectionData { LinkCollectionData& operator=(const LinkCollectionData&) = delete; LinkCollectionData(LinkCollectionData&&) = default; LinkCollectionData& operator=(LinkCollectionData&&) = default; - ~LinkCollectionData() = default; podio::CollectionWriteBuffers getCollectionBuffers(bool isSubsetColl) { return {isSubsetColl ? nullptr : (void*)&m_data, (void*)m_data.get(), &m_refCollections, &m_vecInfo}; diff --git a/include/podio/detail/LinkObj.h b/include/podio/detail/LinkObj.h index ef1860514..c496f8270 100644 --- a/include/podio/detail/LinkObj.h +++ b/include/podio/detail/LinkObj.h @@ -37,9 +37,6 @@ class LinkObj { /// No assignment operator LinkObj& operator=(const LinkObj&) = delete; - /// Destructor - ~LinkObj() = default; - public: podio::ObjectID id{}; LinkData data{1.0f}; diff --git a/include/podio/utilities/DatamodelRegistryIOHelpers.h b/include/podio/utilities/DatamodelRegistryIOHelpers.h index de847ce42..18062902f 100644 --- a/include/podio/utilities/DatamodelRegistryIOHelpers.h +++ b/include/podio/utilities/DatamodelRegistryIOHelpers.h @@ -44,7 +44,6 @@ class DatamodelDefinitionHolder { } DatamodelDefinitionHolder() = default; - ~DatamodelDefinitionHolder() = default; DatamodelDefinitionHolder(const DatamodelDefinitionHolder&) = delete; DatamodelDefinitionHolder& operator=(const DatamodelDefinitionHolder&) = delete; DatamodelDefinitionHolder(DatamodelDefinitionHolder&&) = default; diff --git a/include/podio/utilities/RootHelpers.h b/include/podio/utilities/RootHelpers.h index 360ef6674..e06a4800b 100644 --- a/include/podio/utilities/RootHelpers.h +++ b/include/podio/utilities/RootHelpers.h @@ -30,7 +30,6 @@ namespace root_utils { /// get them from a TTree/TChain for every event. struct CollectionBranches { CollectionBranches() = default; - ~CollectionBranches() = default; CollectionBranches(const CollectionBranches&) = delete; CollectionBranches& operator=(const CollectionBranches&) = delete; CollectionBranches(CollectionBranches&&) = default; @@ -51,7 +50,6 @@ namespace root_utils { template struct ParamStorage { ParamStorage() = default; - ~ParamStorage() = default; ParamStorage(const ParamStorage&) = delete; ParamStorage& operator=(const ParamStorage&) = delete; ParamStorage(ParamStorage&&) = default; diff --git a/python/templates/CollectionData.h.jinja2 b/python/templates/CollectionData.h.jinja2 index 5c7eb690e..7a2fa4af4 100644 --- a/python/templates/CollectionData.h.jinja2 +++ b/python/templates/CollectionData.h.jinja2 @@ -59,11 +59,6 @@ public: {{ class_type }}({{ class_type }}&& other) = default; {{ class_type }}& operator=({{ class_type }}&& other) = default; - /** - * Destructor - */ - ~{{ class_type }}() = default; - void clear(bool isSubsetColl); podio::CollectionWriteBuffers getCollectionBuffers(bool isSubsetColl); diff --git a/python/templates/Interface.h.jinja2 b/python/templates/Interface.h.jinja2 index 82674e0f4..a149e59d7 100644 --- a/python/templates/Interface.h.jinja2 +++ b/python/templates/Interface.h.jinja2 @@ -65,7 +65,6 @@ private: template struct Model final : Concept { - ~Model() = default; Model(ValueT value) : m_value(value) {} std::unique_ptr clone() const final { @@ -115,7 +114,6 @@ public: return *this; } - ~{{ class.bare_type }}() = default; {{ class.bare_type }}({{ class.bare_type }}&&) = default; {{ class.bare_type }}& operator=({{ class.bare_type }}&&) = default; diff --git a/python/templates/macros/declarations.jinja2 b/python/templates/macros/declarations.jinja2 index 80783a30b..1397ff816 100644 --- a/python/templates/macros/declarations.jinja2 +++ b/python/templates/macros/declarations.jinja2 @@ -76,9 +76,6 @@ /// create a mutable deep-copy of the object with identical relations /// if cloneRelations=false, the relations are not cloned and will be empty Mutable{{ type }} clone(bool cloneRelations=true) const; - - /// destructor - ~{{ full_type }}() = default; {% endmacro %}