Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpData equality operator not working in Python #2190

Closed
dweindl opened this issue Nov 14, 2023 · 0 comments · Fixed by #2194
Closed

ExpData equality operator not working in Python #2190

dweindl opened this issue Nov 14, 2023 · 0 comments · Fixed by #2194
Assignees
@dweindl

Comments

@dweindl
Copy link
Member

dweindl commented Nov 14, 2023

assert amici.ExpData(1, 2, 3, [3]) == amici.ExpData(1, 2, 3, [3]) fails. I would expect that to succeed.
Probably operator== isn't handled properly by swig and it just compares addresses.
@dweindl dweindl self-assigned this Nov 15, 2023
dweindl added a commit that referenced this issue Nov 15, 2023
@dweindl
Fix ExpData equality operator for Python
dcbd4a3 
Wasn't automatically handled by swig for unclear reasons. Works now. Fixes #2190.
@dweindl dweindl mentioned this issue Nov 15, 2023
Merged
@dweindl dweindl linked a pull request Nov 20, 2023 that will close this issue
Fix ExpData equality operator for Python #2194
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ExpData equality operator for Python AMICI-dev/AMICI
1 participant
@dweindl