Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: -Werror only for amici repo #2477

Closed
dweindl opened this issue Jul 4, 2024 · 0 comments · Fixed by #2481
Closed

GHA: -Werror only for amici repo #2477

dweindl opened this issue Jul 4, 2024 · 0 comments · Fixed by #2481
Assignees
@dweindl
Labels
ci

Comments

@dweindl
Copy link
Member

dweindl commented Jul 4, 2024

We have a couple of -Werror options enabled when running on GHA. However, we should also check for the repo name. If amici is used in tests of any downstream projects, we don't want errors.

Also use CMake's -Wno-dev for non-amici-ci installations.
@dweindl dweindl self-assigned this Jul 8, 2024
@dweindl dweindl mentioned this issue Jul 8, 2024
Merged
@dweindl dweindl added the ci label Jul 8, 2024
@dweindl dweindl linked a pull request Jul 8, 2024 that will close this issue
GHA: -Werror only for amici repo #2481
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GHA: -Werror only for amici repo dweindl/AMICI
1 participant
@dweindl