Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor true-SDC to not evolve density #2309

Closed
zingale opened this issue Nov 19, 2022 · 2 comments
Closed

refactor true-SDC to not evolve density #2309

zingale opened this issue Nov 19, 2022 · 2 comments
Labels
sdc

Comments

@zingale
Copy link
Member

zingale commented Nov 19, 2022

I think that we can rewrite true SDC to only update (rho X, rho e) through the non-linear solve, just like we do with simplified-SDC. This will allow us to use VODE with the same solution vector y() as the other methods.
@zingale zingale added the sdc label Jul 9, 2023
@zingale
Copy link
Member Author

zingale commented Sep 20, 2023

this is done in #2560

@zingale
Copy link
Member Author

zingale commented Sep 23, 2023

this has been completed

@zingale zingale closed this as completed Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sdc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zingale