From b2716e85b841f521c2284f3703c3012a5470fa39 Mon Sep 17 00:00:00 2001 From: Weiqun Zhang Date: Sat, 21 Dec 2024 09:28:48 -0800 Subject: [PATCH] Fix bug in EBData::randomPointOnEB This is a new function introduced in #4238. --- Src/EB/AMReX_EBData.H | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Src/EB/AMReX_EBData.H b/Src/EB/AMReX_EBData.H index 2ed91af324b..9070fc44f6f 100644 --- a/Src/EB/AMReX_EBData.H +++ b/Src/EB/AMReX_EBData.H @@ -70,7 +70,7 @@ struct EBData Real ymax = std::max(ym,yp); ymin = std::max(ymin, Real(-0.5)); ymax = std::min(ymax, Real( 0.5)); - Real y = rn/(ymax-ymin) + ymin; + Real y = rn*(ymax-ymin) + ymin; Real x = bc0 - (y-bc1)*n1/n0; return amrex::makeTuple(x,y); } @@ -105,7 +105,7 @@ struct EBData Real ymax = std::max(ym,yp); ymin = std::max(ymin, Real(-0.5)); ymax = std::min(ymax, Real( 0.5)); - Real y = amrex::Random(engine)/(ymax-ymin) + ymin; + Real y = amrex::Random(engine)*(ymax-ymin) + ymin; Real z = amrex::Random(engine) - Real(0.5); Real x = bc0 - ((y-bc1)*n1+(z-bc2)*n2)/n0; return amrex::makeTuple(x,y,z); @@ -128,8 +128,8 @@ struct EBData zmax = std::min(zmax, Real( 0.5)); Real x, y, z; do { - y = amrex::Random(engine)/(ymax-ymin) + ymin; - z = amrex::Random(engine)/(zmax-zmin) + zmin; + y = amrex::Random(engine)*(ymax-ymin) + ymin; + z = amrex::Random(engine)*(zmax-zmin) + zmin; x = bc0 - ((y-bc1)*n1+(z-bc2)*n2)/n0; } while (x > Real(0.5) || x < Real(-0.5)); return amrex::makeTuple(x,y,z);