From 7e25e505f14451484a24f486fcf6da07eea4d7c3 Mon Sep 17 00:00:00 2001 From: Weiqun Zhang Date: Tue, 18 Jun 2024 18:09:17 -0700 Subject: [PATCH] Update CI --- .github/workflows/cleanup-cache-postpr.yml | 2 +- .github/workflows/cleanup-cache.yml | 2 +- .github/workflows/cuda.yml | 14 +++++++------- .github/workflows/docs.yml | 2 +- .github/workflows/gcc.yml | 14 +++++++------- .github/workflows/hip.yml | 14 +++++++++----- .github/workflows/post-pr.yml | 2 +- .github/workflows/style.yml | 4 ++-- .github/workflows/sycl.yml | 8 ++++---- 9 files changed, 33 insertions(+), 29 deletions(-) diff --git a/.github/workflows/cleanup-cache-postpr.yml b/.github/workflows/cleanup-cache-postpr.yml index a43b89ee8..d352d47a9 100644 --- a/.github/workflows/cleanup-cache-postpr.yml +++ b/.github/workflows/cleanup-cache-postpr.yml @@ -16,7 +16,7 @@ jobs: env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Clean up ccahe run: | gh extension install actions/gh-actions-cache diff --git a/.github/workflows/cleanup-cache.yml b/.github/workflows/cleanup-cache.yml index 40e376398..3448d88bc 100644 --- a/.github/workflows/cleanup-cache.yml +++ b/.github/workflows/cleanup-cache.yml @@ -16,7 +16,7 @@ jobs: env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Clean up ccahe run: | gh extension install actions/gh-actions-cache diff --git a/.github/workflows/cuda.yml b/.github/workflows/cuda.yml index 6e8332454..8689de021 100644 --- a/.github/workflows/cuda.yml +++ b/.github/workflows/cuda.yml @@ -18,16 +18,16 @@ jobs: env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wlogical-op -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches"} steps: - name: Checkout AMReX-Hydro - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: AMReX-Hydro - name: Checkout AMReX - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: repository: AMReX-Codes/amrex path: amrex - name: Set Up Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.cache/ccache key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} @@ -92,16 +92,16 @@ jobs: env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wlogical-op -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches"} steps: - name: Checkout AMReX-Hydro - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: AMReX-Hydro - name: Checkout AMReX - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: repository: AMReX-Codes/amrex path: amrex - name: Set Up Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.cache/ccache key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} @@ -169,7 +169,7 @@ jobs: PR_NUMBER: ${{ github.event.number }} run: | echo $PR_NUMBER > pr_number.txt - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: pr_number path: pr_number.txt diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 014f83280..7bef53f7b 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -10,7 +10,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: persist-credentials: false diff --git a/.github/workflows/gcc.yml b/.github/workflows/gcc.yml index dc91d2542..a22700439 100644 --- a/.github/workflows/gcc.yml +++ b/.github/workflows/gcc.yml @@ -18,16 +18,16 @@ jobs: env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wnon-virtual-dtor -Wlogical-op -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wmissing-include-dirs"} steps: - name: Checkout AMReX-Hydro - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: AMReX-Hydro - name: Checkout AMReX - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: repository: AMReX-Codes/amrex path: amrex - name: Set Up Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.cache/ccache key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} @@ -88,16 +88,16 @@ jobs: env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wnon-virtual-dtor -Wlogical-op -Wmisleading-indentation -Wduplicated-cond -Wduplicated-branches -Wmissing-include-dirs"} steps: - name: Checkout AMReX-Hydro - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: AMReX-Hydro - name: Checkout AMReX - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: repository: AMReX-Codes/amrex path: amrex - name: Set Up Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.cache/ccache key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} @@ -163,7 +163,7 @@ jobs: PR_NUMBER: ${{ github.event.number }} run: | echo $PR_NUMBER > pr_number.txt - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: pr_number path: pr_number.txt diff --git a/.github/workflows/hip.yml b/.github/workflows/hip.yml index 84ce70d07..b59dd8ef6 100644 --- a/.github/workflows/hip.yml +++ b/.github/workflows/hip.yml @@ -15,19 +15,23 @@ jobs: hip_eb_3d: name: HIP EB 3D runs-on: ubuntu-20.04 - env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-deprecated-declarations -Wno-gnu-zero-variadic-macro-arguments"} + # Have to remove "-fno-operator-names to avoid + # /opt/rocm-6.1.0/include/rocprim/device/detail/device_adjacent_difference.hpp:198:26: error: token is not a valid binary operator in a preprocessor subexpression + # 198 | #if defined(__gfx1102__) or defined(__gfx1030__) + # | ~~~~~~~~~~~~~~~~~~~~~^~ + env: {CXXFLAGS: "-Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-deprecated-declarations -Wno-gnu-zero-variadic-macro-arguments"} steps: - name: Checkout AMReX-Hydro - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: AMReX-Hydro - name: Checkout AMReX - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: repository: AMReX-Codes/amrex path: amrex - name: Set Up Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.cache/ccache key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} @@ -98,7 +102,7 @@ jobs: PR_NUMBER: ${{ github.event.number }} run: | echo $PR_NUMBER > pr_number.txt - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: pr_number path: pr_number.txt diff --git a/.github/workflows/post-pr.yml b/.github/workflows/post-pr.yml index f5b914033..2768ef376 100644 --- a/.github/workflows/post-pr.yml +++ b/.github/workflows/post-pr.yml @@ -13,7 +13,7 @@ jobs: PR_NUMBER: ${{ github.event.number }} run: | echo $PR_NUMBER > pr_number.txt - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: pr_number path: pr_number.txt diff --git a/.github/workflows/style.yml b/.github/workflows/style.yml index 9c3255421..5b5af5e8d 100644 --- a/.github/workflows/style.yml +++ b/.github/workflows/style.yml @@ -10,13 +10,13 @@ jobs: tabs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Tabs run: .github/workflows/style/check_tabs.sh trailing_whitespaces: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Trailing Whitespaces run: .github/workflows/style/check_trailing_whitespaces.sh diff --git a/.github/workflows/sycl.yml b/.github/workflows/sycl.yml index f1f476664..1b0b9e71b 100644 --- a/.github/workflows/sycl.yml +++ b/.github/workflows/sycl.yml @@ -18,16 +18,16 @@ jobs: env: {CXXFLAGS: "-fno-operator-names -Werror -Wall -Wextra -Wpedantic -Wnull-dereference -Wfloat-conversion -Wshadow -Woverloaded-virtual -Wextra-semi -Wunreachable-code -Wnon-virtual-dtor -Wno-sign-compare -Wno-missing-braces"} steps: - name: Checkout AMReX-Hydro - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: AMReX-Hydro - name: Checkout AMReX - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: repository: AMReX-Codes/amrex path: amrex - name: Set Up Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: ~/.cache/ccache key: ccache-${{ github.workflow }}-${{ github.job }}-git-${{ github.sha }} @@ -97,7 +97,7 @@ jobs: PR_NUMBER: ${{ github.event.number }} run: | echo $PR_NUMBER > pr_number.txt - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: pr_number path: pr_number.txt