Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type of timestamp values #17

Open
yilun-zhangs opened this issue Dec 18, 2024 · 1 comment
Open

Data type of timestamp values #17

yilun-zhangs opened this issue Dec 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@yilun-zhangs
Copy link

@jwcullen
In iamf-tools, I checked most timetamp is defined by int32_t,
is it necessary to use int64_t ?

@jwcullen jwcullen added the bug Something isn't working label Dec 18, 2024
@jwcullen
Copy link
Collaborator

jwcullen commented Dec 18, 2024

It is just an internal timestamp. It increases based on the sample rate. It was sort of a leftover from when there was a Sync OBU.

I do see it is small enough to limit encoding to ~12 hrs of 48000 Hz:

  • (2^31 - 1) / 48000 Hz ~= limited to 44739 seconds ~= 12 hrs.

So I'm tagging this as a bug because that limit is plausible to reach. int64_t does seem better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants